propertyTypes in TariffProperty defined as an array

[aqbalahmad]

• propertyTypes in TariffProperty defined as an array of TariffPropertyType.
• It should be a TariffPropertyType as in the API response and in the API definition document: https://developer.genability.com/api-reference/tariff-api/tariff/#get-a-list-of-tariffs

export interface TariffProperty extends GenPropertyKey {
    period?: Period;
    propertyTypes: TariffPropertyType[];
    operator: string;
    propertyValue?: string;
    minValue?: string;
    maxValue?: string;
    isDefault: boolean;
}

[jasonriley]

Correct. Despite the name being plural, it should be signular. Here's the java code on the server.

    public TariffPropertyType getPropertyTypes() {
        return propertyTypes;
    }

    public void setPropertyTypes(TariffPropertyType propertyTypes) {
        this.propertyTypes = propertyTypes;
    }

[aqbalahmad]

Correct. Despite the name being plural, it should be signular. Here's the java code on the server.

  public TariffPropertyType getPropertyTypes() {
      return propertyTypes;
  }

  public void setPropertyTypes(TariffPropertyType propertyTypes) {
      this.propertyTypes = propertyTypes;
  }

Hi @jasonriley

We are still getting propertyTypes in the response from tariff API. It should be propertyType based on changes in this PR. Please look into this ASAP.

It is blocker for this issue.

[jasonriley]

Here's an example from a real tariff. What is the issue here?

  "properties": [
    {
      "keyName": "isNEM2",
      "quantityKey": null,
      "displayName": "Is NEM2 Tariff",
      "family": "billing",
      "keyspace": "electricity",
      "description": "Is this a California NEM 2.0 tariff.  True is a NEM 2.0 tariff, false is NOT a NEM 2.0 tariff.",
      "dataType": "BOOLEAN",
      "propertyTypes": "APPLICABILITY",
      "operator": "=",
      "propertyValue": "false",
      "isDefault": true
    },

I believe the SDK code should be ...

propertyTypes: TariffPropertyType;

We are not changing the server side. Its been that way for 8 years and all our customers use it.

[aqbalahmad]

Ok, I'll change the SDK code for this and merge.