Set chargeType on Tariff Rate Factory - Githubissues

Genability / genability-js

Node.js and Browser Javascript SDK for Genability APIs.

MIT License

0 stars 2 forks source link

Set chargeType on Tariff Rate Factory #210

Closed jasonriley closed 3 years ago

jasonriley commented 3 years ago

The factory methods for getting rates don't set chargeType. Please fix:

createRider is the only one without a chargeType. Please rename this to createRiderRate
createConsumptionRate with chargeType of CONSUMPTION_BASED
createDemandRate with chargeType of DEMAND_BASED
createQuantityRate with chargeType of QUANTITY
createFixedRate with chargeType of FIXED_PRICE
createMinimumRate with chargeType of MINIMUM
createMaximumRate with chargeType of MAXIMUM

Also update all the unit tests to assert that these values are set correctly.