Genaker / FastFPC

Magento 2 improved FPC and Varnish replacement was used for Magento SaaS solution when you need high performace and scaling. No more outdated Adobes official Varnish approach is requred
58 stars 13 forks source link

Feature Request: LZ4 Compression Support #10

Closed Quazz closed 5 days ago

Quazz commented 1 month ago

And possibly other compression types.

https://github.com/Genaker/FastFPC/blob/1632d2cdf81fa6b773e8e2f787160ee67ca5688d/Mage/FPC/FPC.php#L206

Insert something like

        } elseif ($arch === 'l4') {
                return $page = lz4_uncompress(substr($page, 5));
        }

https://github.com/colinmollenhour/Cm_Cache_Backend_Redis/blob/c2e14be4f38fcdc8ecbe609dc173a206db68bf6d/Cm/Cache/Backend/Redis.php#L1330

Can be used as a reference point.

Genaker commented 3 weeks ago

Why do you need another compression? Use the available one. Gzip.

Quazz commented 3 weeks ago

2 reasons:

The original Redis implementation of Magento will prefer basically any compression over gzip, so the transition to this extension would be much smoother if more compression types are supported. (you wont have to flush the entire full page cache)

The other reason is that other compression types offer superior performance in decompression as well as creating much smaller results, meaning less memory used by Redis, allowing for more pages to be cached.

Genaker commented 3 weeks ago

So, this one is not a commercial project. Only Gzip is supported, but if you want to contribute more, you can

On Wed, Oct 23, 2024 at 11:32 PM Quazz @.***> wrote:

2 reasons:

The original Redis implementation of Magento will prefer basically any compression over gzip, so the transition to this extension would be much smoother if more compression types are supported. (you wont have to flush the entire full page cache)

The other reason is that other compression types offer superior performance in decompression as well as creating much smaller results, meaning less memory used by Redis, allowing for more pages to be cached.

— Reply to this email directly, view it on GitHub https://github.com/Genaker/FastFPC/issues/10#issuecomment-2434411641, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACGJNZVGCFCJEXCE565TJH3Z5CH7BAVCNFSM6AAAAABP5ICUDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZUGQYTCNRUGE . You are receiving this because you commented.Message ID: @.***>