GenderAvenger / tally

The Gender Avenger Tally web app
GNU Affero General Public License v3.0
2 stars 2 forks source link

Who Talks sometimes crashes on submit #50

Closed slifty closed 6 years ago

slifty commented 6 years ago

Describe the bug Over the past two weeks there have been four separate reports of issues with the Who Talks feature not generating tallies.

We should treat the timeout and the "mystery issue" as nominally separate, because they manifested in different ways, however as I will note in the diagnosis portion they may well be related

UPDATE: the mystery issue is due to the updating internal routing from a few weeks ago; the re-rendering of the details page was not properly updated to the new view path, which meant if there were validation errors with user input they would be told there was a server problem instead of being shown the form to correct their inputs.

To Reproduce For a while this was a difficult issue to produce. This is because there are actually two issues.

One is the timeout, which resulted in a heroku middleware timeout error. I have not been able to reproduce this but have a sense of a solution anyway.

The other issue is that invalid entries when creating a Who Talks chart results in a server error. Simply try submitting an empty title and you will be able to reproduce the problem.

Expected behavior The server should not time out. The form should properly render when there are validation issues with user data in the Who Talks workflow.

slifty commented 6 years ago

We have now upgraded the Heroku Dyno to a "Professional" instead of a "Hobby" -- this should prevent timeouts in the near future. If we start seeing slow load times then we should at ways to optimize the chart generation.

At this point both issues should be resolved.