search

GenderAvenger / tally

The Gender Avenger Tally web app
GNU Affero General Public License v3.0
2 stars 2 forks source link

Refactor the application #82

Open slifty opened 4 years ago

slifty commented 4 years ago

GA Tally has organically grown for almost 5 years, and though it runs reasonably well it could benefit from a refactor. This is most clear when looking at the fact that our tally-image-generation code is repeated (in slightly different forms) three times for our three tally types.

A refactor would come with the following benefits:

  1. Code would be unit testable (improving stability over time)
  2. Code would be easier to modify for future improvements.
  3. Code would be easier for other potential contributors.
  4. Code would be faster / easier to optimize.

This is a major undertaking that should probably be taken on at a time when we have relative feature stability, but ideally it could be pursued in 2020 at some point.

It would also be related to #68

slifty commented 2 years ago

All right, time to make this actually happen.

This is the best issue to write thoughts in for now, but I imagine it's going to culminate in a larger set of issues. I'd like the refactor to be done in TypeScript. Rather than try to plot the entire plan in an issue I'm going to plot by doing, and spin up issues as I move forward. I'm going to use this issue as a "meta" issue to track, and also am going to create a new "Project" for this refactor.