Closed gjvnq closed 1 year ago
In my experience it didn't break anything but I'll write a short testing program just to be safe.
I had made this change on slugify.js because the links to section headers were not working properly.
On Sun., Oct. 23, 2022, 14:23 Jocelyn Badgley, @.***> wrote:
@.**** commented on this pull request.
In build/lib/slugify.js https://github.com/GenderDysphoria/GenderDysphoria.fyi/pull/111#discussion_r1002742529 :
@@ -1,6 +1,6 @@ const slugs = require('slugify');
module.exports = exports = function slugify (s) {
- const result = slugs(s, { remove: /[*+~.,()'"!?:@/\]/g }).toLowerCase();
- const result = s.trim().replace(/[^\p{L}\p{N}]+/ug, '-').replace(/^-+/, '').replace(/-+$/, '').toLowerCase();
Have you checked if this changes any of the existing urls? I don't want to break any links.
— Reply to this email directly, view it on GitHub https://github.com/GenderDysphoria/GenderDysphoria.fyi/pull/111#pullrequestreview-1152338125, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXIYHC7NMZLN7JAGMDHIODWEVYAVANCNFSM6AAAAAARCA4LNA . You are receiving this because you authored the thread.Message ID: @.*** com>
I did a diff of the build from master vs this branch, and it's looking like they're all identical. We're good to merge, great work!
We're good to merge, great work!
Thanks! I'm flattered!
This is a trimed down version of pull request #109.
I still need to double check the translation to find any mistakes, mispellings, that sort of thing. But I believe it's already possible to review the code changes.
There are two changes not really necessary for the translation itself but that I felt should be included:
_global.scss
that make the fragment links work better.Notes about the translation:
The attached file gdb---pt-light.wacz.txt (remember to rename
.wacz.txt
to.wacz
before trying to view it on https://replayweb.page) is a preview of what the website will look like after this PR.