GenderDysphoria / GenderDysphoria.fyi

Site code
Other
224 stars 63 forks source link

Hungarian translation #83

Closed adeeena closed 2 years ago

adeeena commented 2 years ago

new translation: Hungarian (Magyar)

Thanks!

ErdaradunGaztea commented 2 years ago

About these fonts, I encountered the same problem with German and Polish translations, so there's a SCSS file (scss/_font-compatibility.scss) that uses some other font (one of the default ones, that have characters for most languages) with languages specified. You can add Hungarian in there instead of using substitute letters, if you want :)

(just modify a line to say html[lang=de], html[lang=hu] instead of html[lang=de], should be enough)

adeeena commented 2 years ago

About these fonts, I encountered the same problem with German and Polish translations, so there's a SCSS file (scss/_font-compatibility.scss) that uses some other font (one of the default ones, that have characters for most languages) with languages specified. You can add Hungarian in there instead of using substitute letters, if you want :)

(just modify a line to say html[lang=de], html[lang=hu] instead of html[lang=de], should be enough)

I tried applying the changes in the file provided, but the result is sadly less satisfying than before. I keep my pull request as is.

ErdaradunGaztea commented 2 years ago

I think there is one thing missing, shouldn't you include Hungarian _concat.json file in build/_concats.js? I might be wrong about that, obviously.

adeeena commented 2 years ago

I think there is one thing missing, shouldn't you include Hungarian _concat.json file in build/_concats.js? I might be wrong about that, obviously.

Nice catch! Although in that case, the contributing.md file should also be updated for all these remarks.

ErdaradunGaztea commented 2 years ago

It's a recent development, that's why it's missing. But I was thinking about updating it with my experience translating, I guess I'll have some time now that we finished Polish translation ("lost" with you by mere 6 hours xd).

adeeena commented 2 years ago

("lost" with you by mere 6 hours xd).

I'm sorry, I was not aware we are competing. Although I think we all are winers for contributing in such projects. 👑

Twipped commented 2 years ago

Few images rewritten for Hungarian text (remark: as there were no indication of what font was used, I picked ones with similar style, but maybe for the further translators it might be helpful to have a template/ttf/guide provided)

Font isn't all that important. Many of the images were sourced around the web. The main site logo is made in Acorn, and the file for it is in /resources. https://github.com/GenderDysphoria/GenderDysphoria.fyi/blob/master/resources/gdb.acorn I've gone ahead and produced new titlecards for both this and the polish translation.

No PDF was made from my translation -- is there any way of concatenating it nicely? Will you do it?

The PDFs are all WAY behind, I need to create an automated process for generating them, it's too much of a pain to do it by hand. I'm basically just exporting the print concat version as a PDF from a browser.

Is there any way to display the translator name somewhere in the translated page?

Absolutely, we can put it on the introduction page in the sidebar. What name would you like?" Same for you, @ErdaradunGaztea

adeeena commented 2 years ago

I would prefer showing my full name, "Adéna Muráncsik" if possible.

Although maybe on the introduction page, for the markdown you could pick that value from a metadata tag, wouldn't it be more versatile?

ErdaradunGaztea commented 2 years ago

"Laura Bąkała". Though I worry that adding translators' names might run into the same set of issues as "authoring" a Wikipedia article. I had a little help with translation, for example, where one person translated chapters 4 & 8, and the other did the intro.