search

GenderedIntelligence / the-trans-dimension

The Trans Dimension is an online community hub connecting trans communities in London.
http://transdimension.uk
Other
3 stars 1 forks source link

Use full URLs for favicons #319

Closed ivan-kocienski-gfsc closed 1 year ago

ivan-kocienski-gfsc commented 1 year ago

Closes #247

Description

Using environment constant canonicalUrl

netlify[bot] commented 1 year ago

Deploy Preview for transdimension ready!

Name Link
Latest commit 612d582bb054b0a62ad574e5e5b00121a77e7587
Latest deploy log https://app.netlify.com/sites/transdimension/deploys/634550f537bd5f00084f30bb
Deploy Preview https://deploy-preview-319--transdimension.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

aaaaargZombies commented 1 year ago

OK I'm fairly certain that the main branch is producing absolute URLS combining the Constant.canonicalUrl + Internal URL type. What is a bit confusing is that if you change the canonicalUrl in the .env file and run npm start the dev server still runs on localhoust:3030 but if you inspect the page in the browser you can see the change. If you change it run npm run build then just serve it yourself you can see it all working.

so perhaps we should close this PR and mark the issue as OK?

ivan-kocienski-gfsc commented 1 year ago

This fix is no longer required as the ticket was closed for other reasons