search

GenderedIntelligence / the-trans-dimension

The Trans Dimension is an online community hub connecting trans communities in London.
http://transdimension.uk
Other
3 stars 1 forks source link

Clean up unused code, comments, etc #331

Closed erbridge closed 1 year ago

erbridge commented 1 year ago

Description

The commits explain themselves.

cloudflare-pages[bot] commented 1 year ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1432976
Status: ✅  Deploy successful!
Preview URL: https://71427713.transdimension.pages.dev
Branch Preview URL: https://clean-unused.transdimension.pages.dev

View logs

katjam commented 1 year ago

@erbridge did you use Elm tooling for this? Or should we action that after?

See this closed issue - we decided not to prioritise code linting integration for this project. https://github.com/GenderedIntelligence/the-trans-dimension/issues/78

erbridge commented 1 year ago

I used my editor integration to highlight them with a manual review (which I was doing anyway to spot any outstanding issues).

erbridge commented 1 year ago

Nice to know there are tools for this :)

katjam commented 1 year ago

@erbridge I'm going to go ahead and fix the conflict and merge in the interests of time since you're not back til Weds.

erbridge commented 1 year ago

It doesn't feel urgent @katjam. I'm happy to resolve it on Wednesday.

erbridge commented 1 year ago

Feel free to merge if you're done, though :)

katjam commented 1 year ago

We're planning to go live on Weds. #354