Accessibility enhancements overall checklist

[ivan-kocienski-gfsc]

Plan

• [ ] Consider checklist items, group things that can be tackled together and create a linked issue before working on
• [ ] Some of these items good first issue. Please label as such if you convert to linked issue

Following on from #39

A list of fixes to improve accessibility

• [x] #334
• [x] #335
• [x] #338
• [x] #340
• [x] #342
• [ ] The beta banner is non-tabable and cannot be dismissed.
• [ ] The tab index position does not reset on keyboard (or mouse) navigation

About

• [ ] "follow us out there" should be a heading
• [ ] "created by" should be a heading ? (this recommendation came from WAVE)
• [ ] About: "Find out more" string should be in copy (more of a chore)

Join Us

• [ ] "want to be listed on the trans dimension?" should be a heading
• [ ] maybe "i'd like:" should be a heading (?)
• [x] #347

Index

• [ ] maybe "View all events" redundant link (duplicate of top-of-page navigation?)
• [ ] The latest news section is skipped entirely except for the "Read the rest" and "view all news". Maybe a clickable title or a clickable image with alt text?

Partners Index

• [x] #336
• [x] #416

News Index

• [ ] - All the news links are "Read the rest" (repetition)

Partner Show

• [ ] In contact section- there is an empty link (no href, no text).
• [ ] blank link after get in touch email link and before upcoming event list

News Show

• [ ] Missing alt text on img?

Event Show

• [x] #337

404 Page

• [ ] Should be title? "This page could not be found"

Misc

• [ ] Footer: viewPageFooter logo and viewPageFooterCredit missing alt text

[katjam]

@erbridge can you cross ref these list items with your recent PRs? Then we can convert the rest as we go so we don't double up because I think @ivan-kocienski-gfsc will also be fixing some of these in the next day or 2.

[erbridge]

Done

[kimadactyl]

This is too much for public release deadline. Blocking/critical issues only should be made into new tickets and added back into the launch ticket in time for Mon 31st Oct.

[katjam]

@studiosquid For this one - just review the outstanding work and if there is any list item that feels important then convert it and add to the bottom of milestone.

Shall we... 1) add to the bottom of work queue, 2) close as a won't fix, 3) leave open for future niceness but not important now.

[studiosquid]

@katjam sorry I don't really know what is meant by "Convert it and add to bottom of milestone" I'm pretty basic in Github. Do you mean make it a separate ticket?

The one that stood out to me as it's my fault:

Partners index

low contrast warning on Partner title pill (the bit next to the name with the location)

This being inaccessible isn't ideal — can we change the hex value for this colour from 683A65 to 432955 this gives us AA access contrast.

Most of these don't stand out to me as they're code based so I don't know the level of severity — if there's bad practice going on then ideally it would be good to resolve things so rate them a 3

[katjam]

I'll pop that contrast one in the milestone and leave the rest for picking off later.