GenderedIntelligence / the-trans-dimension

The Trans Dimension is an online community hub connecting trans communities in the UK.
http://transdimension.uk
Other
3 stars 1 forks source link

Feature: show only future events on partner page #356

Closed ivan-kocienski-gfsc closed 1 year ago

ivan-kocienski-gfsc commented 1 year ago

Fixes #347

On partner's page, only show events from this partner that are in the future

cloudflare-workers-and-pages[bot] commented 1 year ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8bfcb1f
Status: ✅  Deploy successful!
Preview URL: https://10fcb45b.transdimension.pages.dev
Branch Preview URL: https://ik-347-partner-events-in-fut.transdimension.pages.dev

View logs

erbridge commented 1 year ago

Which issue is this fixing? Looks like the linked one is related to "Join us".

erbridge commented 1 year ago

Ok. Found it (it's #346). That issue description says:

If a partner has more than 20 events, they will be paginated with the weekly filter. If there are less than 20, display the "All events" and "Future events" filter buttons. Default to filter.

Can we do that full change, please so we don't block visibility of past events for small venues (where past events are even more important to show that they're real and active).

ivan-kocienski-gfsc commented 1 year ago

So in a conversation with @katjam we decided it would be easier to have the logic where if a partner has less than 20 events there's a list of "Upcoming Events" and below that there is a list of "Previous Events" (these sections are visible only if there are actual entries).

katjam commented 1 year ago

So in a conversation with @katjam we decided it would be easier to have the logic where if a partner has less than 20 events there's a list of "Upcoming Events" and below that there is a list of "Previous Events" (these sections are visible only if there are actual entries).

Yes - we kind of decided this was the path or least resistance - for now.

katjam commented 1 year ago

Hey @ivan-kocienski-gfsc - as with the other, I am merging for you in the interest of time.