Improve logo markup - Githubissues

GenderedIntelligence / the-trans-dimension

The Trans Dimension is an online community hub connecting trans communities in the UK.

http://transdimension.uk

Other

3 stars 1 forks source link

Improve logo markup #370

Closed erbridge closed 1 year ago

erbridge commented 1 year ago

Use alt text instead of complex hidden images and visibly hidden spans.
Drop the invisible and confusing link to the home page. We already have a link to take us home in the header, and this one had no indication it was a link and a very wide catchment area for that link.

This change brought to you by me scrolling to the top of the page and clicking somewhere on the background and being navigated somewhere very unexpectedly.

cloudflare-workers-and-pages[bot] commented 1 year ago

Deploying with Cloudflare Pages

Latest commit:	`ed38485`
Status:	✅ Deploy successful!
Preview URL:	https://3663a6e5.transdimension.pages.dev
Branch Preview URL:	https://better-logo-markup.transdimension.pages.dev

View logs

katjam commented 1 year ago

I'm happy with this - especially the use of alt text for description - but it is a little in conflict with #359 which indicates that we prefer the logo to link to home.

As with other "fixes" - was this raised as an issue or just something you decided to do? I'm still concerned that we should not be doing ad-hoc unplanned work.

katjam commented 1 year ago

@kimadactyl I think you may have been the one to raise the logo not linking on mobile. In light of that, are you happy for this to be merged?

kimadactyl commented 1 year ago

Build currently failing so can't review but I'm sure it's fine no need to get signoff from me :)

katjam commented 1 year ago

In that case I guess I will mark #359 as closed by this also.