Improve text shown for past events when none exist

GenderedIntelligence / the-trans-dimension

The Trans Dimension is an online community hub connecting trans communities in London.

http://transdimension.uk

Other

3 stars 1 forks source link

Improve text shown for past events when none exist #382

Closed r-ferrier closed 1 year ago

r-ferrier commented 1 year ago

Fixes #361

Description

When a partner has > 20 events and past events is selected, if none exist then the text shown now is

There were no past events.

A test has been added to catch this edge case

Please let me know what the copy should be here if this is not suitable - I just went with something simple for now!

cloudflare-pages[bot] commented 1 year ago

Deploying with Cloudflare Pages

Latest commit:	`4b8b1af`
Status:	✅ Deploy successful!
Preview URL:	https://d9fcfd28.transdimension.pages.dev
Branch Preview URL:	https://fix-361-past-events-use-wron.transdimension.pages.dev

View logs

r-ferrier commented 1 year ago

@katjam Unfortunately the build is now failing! Have tried re-running it to no avail. What's the best thing for me to do here - is this a regular occurrence? Should I make an empty commit to trigger a rebuild? Or is this something I'd need to check out in cloudflare once I have access?

katjam commented 1 year ago

I will look at it. I think it's to do with Cloudflare and the way it manages node dependencies.

katjam commented 1 year ago

I think maybe with this one, the failure was too many running at the same time. I'm going to trigger again.