search

GeneDx / phenopy

Phenotype comparison tools using semantic similarity.
Other
55 stars 11 forks source link

Added support for Lin similarity measure #58

Closed ldingemans closed 1 year ago

ldingemans commented 3 years ago

Added support for Lin similarity measure

arvkevi commented 3 years ago

Hi @ldingemans 👋 thanks for opening the pull request.

It would be nice to:

  1. add tests for the Lin scoring to test_score.py.
  2. change the if: else: to a try: except ZeroDivisionError: -- as I think we'd see a small speedup.

We can implement those changes in the next few days, but feel free to give it a shot!