search

Genentech / FacileDataSet

A fluent API for accessing multi-assay high-throughput genomics data.
MIT License
4 stars 0 forks source link

Feature/csurv type #14

Closed phaverty closed 6 years ago

phaverty commented 6 years ago

This implements the "cSurv" type which is a character representation of a Surv. This allows Surv pData columns to survive the trip through the EAV table. Converting cSurv to Surv is supported and can happen just before survival analysis.

lianos commented 6 years ago

Will take a peak tonight!

phaverty commented 6 years ago

bump, is blocker for my next moves

lianos commented 6 years ago

doing this right now

phaverty commented 6 years ago

Yes, I just figured out how to make emacs do 2 spaces per tab for R files. I'll re-flow the files I edited. Also, we'll probably go to something like stylr. (I'd like to see that as a server-side push hook.)

phaverty commented 6 years ago

You are correct that the test for eav-ing Surv is no longer necessary. I hoped to just make Surv->cSurv->character part of of the eav-ing. That broke the creation of the default YAML stuff, so I punted and added a for loop to the top of the EAV table maker that just makes all the Surv columns cSurv. I'll drop the unnecessary test.

lianos commented 6 years ago

+1 for stylr, although it will be very unhappy at first

... also, kudos to you for still sticking to your emacs convictions ...