search

Genentech / FacileDataSet

A fluent API for accessing multi-assay high-throughput genomics data.
MIT License
4 stars 0 forks source link

R CMD check clean #2

Open phaverty opened 6 years ago

phaverty commented 6 years ago

We pass check, but there are odds and ends of undocumented args and functions. I want to get to zero warnings before making this repo fully public. Well, zero not counting all the check clutter you get from NSE variables in the tidyverse.

Steve, you had some great momentum going on this. Wanna finish it off :-) ?

lianos commented 6 years ago

I'll be working on this and random tweaks for a "clean" install on a vanilla machine in the prepublic-cleanup branch.

lianos commented 6 years ago

Note to self: you might try using the dplyr .data pronoun with @importFrom rlang .data to run around NSE notes/warnings in R CMD check, as described in the last part of the Programming recipes section in the "Programming with dplyr" article.

... Or, maybe not. Just keep in mind issues they need to work out when we are talking to a dbplyr backend:

https://github.com/tidyverse/dbplyr/issues/132

There is a work around that works on dbplyr backends for many dplyr verbs except select and distinct

phaverty commented 5 years ago

ping!

lianos commented 5 years ago

64 bytes from 198.185.159.144: icmp_seq=0 ttl=245 time=75.270 ms 64 bytes from 198.185.159.144: icmp_seq=1 ttl=245 time=75.541 ms 64 bytes from 198.185.159.144: icmp_seq=2 ttl=245 time=75.333 ms 64 bytes from 198.185.159.144: icmp_seq=3 ttl=245 time=74.366 ms

I'm still here, and I I hear you ;-) will keep chipping away this w/e, make you no worry.

-steve

On Thu, Sep 6, 2018 at 9:23 AM Peter Haverty notifications@github.com wrote:

ping!

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Genentech/FacileDataSet/issues/2#issuecomment-419156274, or mute the thread https://github.com/notifications/unsubscribe-auth/AABjmLtykk_OuTJD4UlU5xJ4pL_4tXljks5uYUvvgaJpZM4TiBt_ .