search

Genentech / FacileDataSet

A fluent API for accessing multi-assay high-throughput genomics data.
MIT License
4 stars 0 forks source link

Feature/for facile analysis #23

Open phaverty opened 5 years ago

phaverty commented 5 years ago

Fixes #2 (enough) Breaking as it requires FacileAnalysis. I aim to open source FacileAnalysis in the next few weeks. We can move this to master when that happens.

lianos commented 5 years ago

Problem is that this will hose me and my efforts in the meantime

phaverty commented 5 years ago

Please commit said efforts :-)

Pete

Peter M. Haverty, Ph.D. Genentech, Inc. phaverty@gene.com

On Fri, Sep 21, 2018 at 3:30 PM, Steve Lianoglou notifications@github.com wrote:

Problem is that this will hose me and my efforts in the meantime

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Genentech/FacileDataSet/pull/23#issuecomment-423687824, or mute the thread https://github.com/notifications/unsubscribe-auth/AH02K9SI6hNzxlPxIrGr5xyXpT8mmEQHks5udWh2gaJpZM4W08ae .

phaverty commented 5 years ago

FacileAnalysis will be along shortly. I can leave this unmerged, or just merge to develop, leaving master unchanged. Thoughts?

phaverty commented 5 years ago

Actually, I'll hold off touching develop until after Vincent releases the Q3 version. This should be in a week or so. FacileAnalysis/FacileData will get a quick bluesheet once I've got a FacileSummarizedExperiment to test against. This requires just the 15 FacileInterface functions and will let me type out a simple example SE in the test code.

lianos commented 5 years ago

At this point, merging into develop doesn't affect me since develop already has FacileAnalysis as listed as a dependency, so have at it (assuming @VRouilly is ok with you merging into develop, that is).

In the interim, I'm not sure how best I can help. I was thinking to just focus on writing vignette(s).

In order to do so, I will try to write these as a branch off of the very last commit to develop before FacileAnalysis was introduced, OK?

Update: which I've done with this branch, which was created from the develop branch after the 331e5e0 commit

phaverty commented 5 years ago

Yes, the vignettes would really help.

Pete

Peter M. Haverty, Ph.D. Genentech, Inc. phaverty@gene.com

On Wed, Sep 26, 2018 at 11:16 AM, Steve Lianoglou notifications@github.com wrote:

At this point, merging into develop doesn't affect me since develop already has FacileAnalysis as listed as a dependency, so have at it (assuming @VRouilly https://github.com/VRouilly is ok with you merging into develop, that is).

In the interim, I'm not sure how best I can help. I was thinking to just focus on writing vignette(s).

In order to do so, I will try to write these as a branch off of the very last commit to develop before FacileAnalysis was introduced, OK?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Genentech/FacileDataSet/pull/23#issuecomment-424818069, or mute the thread https://github.com/notifications/unsubscribe-auth/AH02K7N0Hmt0cxv7NvG9LW35O2LCjzWzks5ue8RqgaJpZM4W08ae .