What does V8 here? - Githubissues

Genentech / FacileDataSet

A fluent API for accessing multi-assay high-throughput genomics data.

MIT License

4 stars 0 forks source link

What does V8 here? #24

Closed phaverty closed 5 years ago

phaverty commented 5 years ago

FacileExplorer uses V8. It's a tough dependency. What is is used for?

jonocarroll commented 5 years ago

We can find out... just grep "V8::"... oh, right. :stuck_out_tongue_winking_eye:

phaverty commented 5 years ago

Cute :-) Luckily V8 exports only 3 functions and we do not use them. Looks like it works without V8.

lianos commented 5 years ago

I believe it's required due to some mojo I was trying to use with shinyjs.

I also have V8 as an import on my multiGSEA.shiny package, which TFE uses quite a bit.

Pretty sure you can't nuke it. What's so tough about the dependency? Havent had a problem with it ... even when having to deploy on GNE infrastructure ;-)

phaverty commented 5 years ago

Looks like V8 is actually needed. The V8 system library is a bit of a hassle for some of our dedicated machines that we are building. We'll sort it out.