search

Genentech / jmpost

https://genentech.github.io/jmpost/
17 stars 4 forks source link

Create Vignettes #128

Open gowerc opened 1 year ago

gowerc commented 1 year ago

Currently the "vignettes" are a bunch of scattered markdown files. Need to consolidate these into a proper vignette

mercifr1 commented 7 months ago

Hi Craig, I would consider putting the .gdoc(s) I have presented to you and Daniel on OS into a vignette format. Do you have a template for this? Should I create a branch for this? Thanks for your guidance.

gowerc commented 7 months ago

@mercifr1 - We don't have a formal template though I would recommend looking at the existing vignette/*.Rmd files as these are likely already setup in a sufficient way.

Yes I would recommend creating a branch, making your changes in the branch, and then submitting a merge-request on GitHub to merge your branch into main. This then gives Daniel and I the chance to review and comment on the changes.

Let me know if you need any additional support with this.