Genentech / psborrow2

psborrow2: Bayesian Dynamic Borrowing Simulation Study and Analysis
https://genentech.github.io/psborrow2/
Other
16 stars 2 forks source link

Cleaning up some CRAN checks in preparation of 0.0.3 #247

Closed mattsecrest closed 11 months ago

mattsecrest commented 11 months ago

devtools::release() now good.

gravesti commented 11 months ago

Ah, I was thinking of Additional_repositories, see https://cran.r-project.org/web/packages/policies.html I guess we can add https://mc-stan.org/r-packages/ there

On Mon, 27 Nov 2023 at 20:41, Matt Secrest @.***> wrote:

@.**** commented on this pull request.

In DESCRIPTION https://github.com/Genentech/psborrow2/pull/247#discussion_r1406660083:

-Remotes:

  • @.***

@gravesti https://github.com/gravesti good question. This is the message from devtools::release_checks():

✖ WARNING: Remotes field should be removed before CRAN submission.

— Reply to this email directly, view it on GitHub https://github.com/Genentech/psborrow2/pull/247#discussion_r1406660083, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT6IXOBJP4CTWMRZYZO5PYTYGTUFBAVCNFSM6AAAAAA74OC6XWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJRGIZDIMZUGI . You are receiving this because you were mentioned.Message ID: @.***>

--

Isaac Gravestock, PhD

Data Scientist

Real World Data, PD Data Sciences

F.Hoffmann - La Roche Ltd

Tel: (+41) 79 158 31 85

e-mail: @. @.>

mattsecrest commented 11 months ago

Yeah let's give that a go. The commit is still being processed right now.

mattsecrest commented 11 months ago

@gravesti green checks!