Closed gravesti closed 7 months ago
@gravesti just wondering around naming. This is the UI in my understanding (prepping for investigator meeting):
Do you agree w/ this UI? If so, I wonder if set_transformations()
and set_event_dist()
make more sense? Same thought for the DataSimEnrollment
constructor. Maybe set_data_sim_enrollment()
?
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:
@gravesti just wondering around naming. This is the UI in my understanding (prepping for investigator meeting):
Do you agree w/ this UI? If so, I wonder if
set_transformations()
andset_event_dist()
make more sense? Same thought for theDataSimEnrollment
constructor. Maybeset_data_sim_enrollment()
?
add_transformations
to set_transformations
👍 set_*
functions are optional I think.DataSimEvent
object is required for create_data_simulation()
. Maybe event_dist()
should be create_event_dist()
set_enrollment()
. I don't know if set_data_sim_enrollment()
is friendlier?@gravesti just wondering around naming. This is the UI in my understanding (prepping for investigator meeting): Do you agree w/ this UI? If so, I wonder if
set_transformations()
andset_event_dist()
make more sense? Same thought for theDataSimEnrollment
constructor. Maybeset_data_sim_enrollment()
?
- we could change
add_transformations
toset_transformations
👍- From this UI all the
set_*
functions are optional I think.- Whereas an
DataSimEvent
object is required forcreate_data_simulation()
. Maybeevent_dist()
should becreate_event_dist()
- We have the DataSimEnrollment constructor for custom enrollment functions. These would still be used with
set_enrollment()
. I don't know ifset_data_sim_enrollment()
is friendlier?
set_transformations
create_event_dist
sounds good. maybe specify_event_dist()
and specify_baseline_vars()
?set_enrollment
create_event_dist()
Feature branch to add data simulation
Open issues
DataSimEnrollment
objectscreate_baseline_object
s, maybec()
?SimDataList@data_list[[i]]
[x] only allow 1 drift?