Genentech / psborrow2

psborrow2: Bayesian Dynamic Borrowing Simulation Study and Analysis
https://genentech.github.io/psborrow2/
Other
16 stars 2 forks source link

simulate event data (#259) #262

Closed gravesti closed 7 months ago

gravesti commented 8 months ago

Feature branch to add data simulation

Open issues

mattsecrest commented 7 months ago

@gravesti just wondering around naming. This is the UI in my understanding (prepping for investigator meeting):

psborrow2_data_simulation

Do you agree w/ this UI? If so, I wonder if set_transformations() and set_event_dist() make more sense? Same thought for the DataSimEnrollment constructor. Maybe set_data_sim_enrollment()?

codecov-commenter commented 7 months ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

gravesti commented 7 months ago

@gravesti just wondering around naming. This is the UI in my understanding (prepping for investigator meeting):

Do you agree w/ this UI? If so, I wonder if set_transformations() and set_event_dist() make more sense? Same thought for the DataSimEnrollment constructor. Maybe set_data_sim_enrollment()?

mattsecrest commented 7 months ago

@gravesti just wondering around naming. This is the UI in my understanding (prepping for investigator meeting): Do you agree w/ this UI? If so, I wonder if set_transformations() and set_event_dist() make more sense? Same thought for the DataSimEnrollment constructor. Maybe set_data_sim_enrollment()?

  • we could change add_transformations to set_transformations 👍
  • From this UI all the set_* functions are optional I think.
  • Whereas anDataSimEvent object is required for create_data_simulation(). Maybe event_dist() should be create_event_dist()
  • We have the DataSimEnrollment constructor for custom enrollment functions. These would still be used with set_enrollment(). I don't know if set_data_sim_enrollment() is friendlier?
mattsecrest commented 7 months ago