Genentech / psborrow2

psborrow2: Bayesian Dynamic Borrowing Simulation Study and Analysis
https://genentech.github.io/psborrow2/
Other
16 stars 2 forks source link

CRAN updates and clean #271

Closed mattsecrest closed 5 months ago

mattsecrest commented 5 months ago
codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 21.21212% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 79.23%. Comparing base (cbef176) to head (6fcd173).

:exclamation: Current head 6fcd173 differs from pull request most recent head add107e. Consider uploading reports for the commit add107e to get more accurate results

Files Patch % Lines
R/simulation_class.R 0.00% 15 Missing :warning:
R/mcmc_sample.R 0.00% 7 Missing :warning:
R/analysis_class.R 0.00% 3 Missing :warning:
R/generics.R 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #271 +/- ## ========================================== - Coverage 80.47% 79.23% -1.25% ========================================== Files 60 60 Lines 1588 1613 +25 ========================================== Hits 1278 1278 - Misses 310 335 +25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mattsecrest commented 5 months ago

Getting an error on winbuilder 00check.log.txt

gravesti commented 5 months ago

@mattsecrest I think I've fixed the failing test and the note about the URLs. I've uploaded again to winbuilder

mattsecrest commented 5 months ago
mattsecrest commented 5 months ago

@gravesti good catch on the (x) functionality. Anything else before we submit? I figure we can build and submit from this branch then merge when accepted?