search

Genentech / psborrow2

psborrow2: Bayesian Dynamic Borrowing Simulation Study and Analysis
https://genentech.github.io/psborrow2/
Other
16 stars 2 forks source link

CRAN submission light edits #276

Closed mattsecrest closed 5 months ago

mattsecrest commented 5 months ago

@gravesti @danielinteractive couple NOTEs on first submit: Roche.Mail.-.CRAN.Submission.psborrow2.0.0.3.2.pdf

Will still get the spelling and dependency note on resubmission but I assume we all agree those are fine. I suppose after I resubmit and a similar email is sent, I just respond by email per this line:

If you are fairly certain the rejection is a false positive, please reply-all to this message and explain.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.41%. Comparing base (f24f512) to head (b7a6475).

:exclamation: Current head b7a6475 differs from pull request most recent head 1e0be3b. Consider uploading reports for the commit 1e0be3b to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #276 +/- ## ======================================= Coverage 79.41% 79.41% ======================================= Files 60 60 Lines 1613 1613 ======================================= Hits 1281 1281 Misses 332 332 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danielinteractive commented 5 months ago

looks good, thanks @mattsecrest !

mattsecrest commented 5 months ago

@gravesti @danielinteractive would you mind approving if you have a minute?