Closed lfrohman closed 8 years ago
Hei Lance Thanks a lot
All this looks perfectly fine for me. Thanks a lot to make this project fly!
Alex
On Tue, Nov 3, 2015 at 6:42 PM, Lance Frohman notifications@github.com wrote:
also one off fix option expose default appender,positioner resizing
group set padding
You can view, comment on, or merge this pull request online at:
https://github.com/Genentech/pviz/pull/8 Commit Summary
- new features collapser, selection
File Changes
- M dist/pviz-amd.js https://github.com/Genentech/pviz/pull/8/files#diff-0 (316)
- M dist/pviz-amd.min.js https://github.com/Genentech/pviz/pull/8/files#diff-1 (4)
- M dist/pviz-bundle.js https://github.com/Genentech/pviz/pull/8/files#diff-2 (562)
- M dist/pviz-bundle.min.js https://github.com/Genentech/pviz/pull/8/files#diff-3 (32)
- M dist/pviz-core.css https://github.com/Genentech/pviz/pull/8/files#diff-4 (37)
- M examples/deps/bootstrap-theme.min.css https://github.com/Genentech/pviz/pull/8/files#diff-5 (4)
- M examples/deps/bootstrap.min.css https://github.com/Genentech/pviz/pull/8/files#diff-6 (4)
- M examples/deps/pviz-bundle.min.js https://github.com/Genentech/pviz/pull/8/files#diff-7 (32)
- M examples/deps/pviz-core.css https://github.com/Genentech/pviz/pull/8/files#diff-8 (37)
- M examples/doc/DASReader.js.html https://github.com/Genentech/pviz/pull/8/files#diff-9 (2)
- M examples/doc/DetailsPane.js.html https://github.com/Genentech/pviz/pull/8/files#diff-10 (2)
- M examples/doc/FastaReader.js.html https://github.com/Genentech/pviz/pull/8/files#diff-11 (2)
- M examples/doc/FeatureDisplayer.js.html https://github.com/Genentech/pviz/pull/8/files#diff-12 (17)
- M examples/doc/FeatureLayer.js.html https://github.com/Genentech/pviz/pull/8/files#diff-13 (2)
- M examples/doc/FeatureLayerCollection.js.html https://github.com/Genentech/pviz/pull/8/files#diff-14 (2)
- M examples/doc/FeatureLayerView.js.html https://github.com/Genentech/pviz/pull/8/files#diff-15 (13)
- M examples/doc/FeatureManager.js.html https://github.com/Genentech/pviz/pull/8/files#diff-16 (2)
- M examples/doc/GGplot2Adapter.js.html https://github.com/Genentech/pviz/pull/8/files#diff-17 (2)
- M examples/doc/HiddenLayersView.js.html https://github.com/Genentech/pviz/pull/8/files#diff-18 (2)
- M examples/doc/OneLiner.js.html https://github.com/Genentech/pviz/pull/8/files#diff-19 (2)
- M examples/doc/PositionedFeature.js.html https://github.com/Genentech/pviz/pull/8/files#diff-20 (2)
- M examples/doc/SeqEntry.js.html https://github.com/Genentech/pviz/pull/8/files#diff-21 (2)
- M examples/doc/SeqEntryAnnotInteractiveView.js.html https://github.com/Genentech/pviz/pull/8/files#diff-22 (150)
- M examples/doc/SeqEntryFastaView.js.html https://github.com/Genentech/pviz/pull/8/files#diff-23 (2)
- M examples/doc/SeqEntryTableView.js.html https://github.com/Genentech/pviz/pull/8/files#diff-24 (2)
- M examples/doc/SeqEntryViewport.js.html https://github.com/Genentech/pviz/pull/8/files#diff-25 (108)
- M examples/doc/TypedDisplayer.js.html https://github.com/Genentech/pviz/pull/8/files#diff-26 (32)
- M examples/doc/global.html https://github.com/Genentech/pviz/pull/8/files#diff-27 (2)
- M examples/doc/index.html https://github.com/Genentech/pviz/pull/8/files#diff-28 (2)
- M examples/doc/module-DASReader-DASReader.html https://github.com/Genentech/pviz/pull/8/files#diff-29 (2)
- M examples/doc/module-DASReader.html https://github.com/Genentech/pviz/pull/8/files#diff-30 (2)
- M examples/doc/module-DetailsPane-DetailsPane.html https://github.com/Genentech/pviz/pull/8/files#diff-31 (6)
- M examples/doc/module-DetailsPane.html https://github.com/Genentech/pviz/pull/8/files#diff-32 (2)
- M examples/doc/module-FastaReader-FastaReader.html https://github.com/Genentech/pviz/pull/8/files#diff-33 (2)
- M examples/doc/module-FastaReader.html https://github.com/Genentech/pviz/pull/8/files#diff-34 (2)
- M examples/doc/module-FeatureDisplayer-FeatureDisplayer.html https://github.com/Genentech/pviz/pull/8/files#diff-35 (23)
- M examples/doc/module-FeatureDisplayer.html https://github.com/Genentech/pviz/pull/8/files#diff-36 (2)
- M examples/doc/module-FeatureLayer-FeatureLayer.html https://github.com/Genentech/pviz/pull/8/files#diff-37 (2)
- M examples/doc/module-FeatureLayer.html https://github.com/Genentech/pviz/pull/8/files#diff-38 (2)
- M examples/doc/module-FeatureLayerCollection-FeatureLayerCollection.html https://github.com/Genentech/pviz/pull/8/files#diff-39 (2)
- M examples/doc/module-FeatureLayerCollection.html https://github.com/Genentech/pviz/pull/8/files#diff-40 (2)
- M examples/doc/module-FeatureLayerView-FeatureLayerView.html https://github.com/Genentech/pviz/pull/8/files#diff-41 (8)
- M examples/doc/module-FeatureLayerView.html https://github.com/Genentech/pviz/pull/8/files#diff-42 (2)
- M examples/doc/module-FeatureManager-FeatureManager.html https://github.com/Genentech/pviz/pull/8/files#diff-43 (5)
- M examples/doc/module-FeatureManager.html https://github.com/Genentech/pviz/pull/8/files#diff-44 (2)
- M examples/doc/module-GGPLot2Adapter.html https://github.com/Genentech/pviz/pull/8/files#diff-45 (2)
- M examples/doc/module-HiddenLayersView-HiddenLayersView.html https://github.com/Genentech/pviz/pull/8/files#diff-46 (2)
- M examples/doc/module-HiddenLayersView.html https://github.com/Genentech/pviz/pull/8/files#diff-47 (2)
- M examples/doc/module-OneLiner-OneLiner.html https://github.com/Genentech/pviz/pull/8/files#diff-48 (2)
- M examples/doc/module-OneLiner.html https://github.com/Genentech/pviz/pull/8/files#diff-49 (2)
- M examples/doc/module-PositionedFeature-PositionedFeature.html https://github.com/Genentech/pviz/pull/8/files#diff-50 (2)
- M examples/doc/module-PositionedFeature.html https://github.com/Genentech/pviz/pull/8/files#diff-51 (2)
- M examples/doc/module-SeqEntry-SeqEntry.html https://github.com/Genentech/pviz/pull/8/files#diff-52 (2)
- M examples/doc/module-SeqEntry.html https://github.com/Genentech/pviz/pull/8/files#diff-53 (2)
- M examples/doc/module-SeqEntryAnnotInteractiveView-SeqEntryAnnotInteractiveView.html https://github.com/Genentech/pviz/pull/8/files#diff-54 (309)
- M examples/doc/module-SeqEntryAnnotInteractiveView.html https://github.com/Genentech/pviz/pull/8/files#diff-55 (2)
- M examples/doc/module-SeqEntryFastaView-SeqEntryFastaView.html https://github.com/Genentech/pviz/pull/8/files#diff-56 (2)
- M examples/doc/module-SeqEntryFastaView.html https://github.com/Genentech/pviz/pull/8/files#diff-57 (2)
- M examples/doc/module-SeqEntryTableView-SeqEntryTableView.html https://github.com/Genentech/pviz/pull/8/files#diff-58 (2)
- M examples/doc/module-SeqEntryTableView.html https://github.com/Genentech/pviz/pull/8/files#diff-59 (2)
- M examples/doc/module-SeqEntryViewport-SeqEntryViewport.html https://github.com/Genentech/pviz/pull/8/files#diff-60 (192)
- M examples/doc/module-SeqEntryViewport.html https://github.com/Genentech/pviz/pull/8/files#diff-61 (2)
- M examples/doc/module-TypeDisplayer-TypeDisplayer.html https://github.com/Genentech/pviz/pull/8/files#diff-62 (8)
- M examples/doc/module-TypeDisplayer.html https://github.com/Genentech/pviz/pull/8/files#diff-63 (2)
- A examples/example-collapse.html https://github.com/Genentech/pviz/pull/8/files#diff-64 (226)
- A examples/example-select.html https://github.com/Genentech/pviz/pull/8/files#diff-65 (176)
- A examples/images/example-collapse.jpg https://github.com/Genentech/pviz/pull/8/files#diff-66 (0)
- A examples/images/example-select.jpg https://github.com/Genentech/pviz/pull/8/files#diff-67 (0)
- M examples/index.html https://github.com/Genentech/pviz/pull/8/files#diff-68 (22)
- M src/css/pviz-core.css https://github.com/Genentech/pviz/pull/8/files#diff-69 (37)
- M src/js/views/FeatureDisplayer.js https://github.com/Genentech/pviz/pull/8/files#diff-70 (15)
- M src/js/views/FeatureLayerView.js https://github.com/Genentech/pviz/pull/8/files#diff-71 (11)
- M src/js/views/SeqEntryAnnotInteractiveView.js https://github.com/Genentech/pviz/pull/8/files#diff-72 (148)
- M src/js/views/SeqEntryViewport.js https://github.com/Genentech/pviz/pull/8/files#diff-73 (106)
- M src/js/views/TypedDisplayer.js https://github.com/Genentech/pviz/pull/8/files#diff-74 (30)
Patch Links:
— Reply to this email directly or view it on GitHub https://github.com/Genentech/pviz/pull/8.
Alexandre Masselot
http://alexandre-masselot.blogspot.ch http://alexandre-masselot.blogspot.com// http://alexandre-masselot.blogspot.ch/ h http://mtroopgoeswest.blogspot.ch/ttp://www.framexpeditions.com
And by the way, you might check out with Kiran to be able to push on master ;)
On Wed, Nov 4, 2015 at 5:02 PM, Alexandre Masselot < alexandre.masselot@gmail.com> wrote:
Hei Lance Thanks a lot
All this looks perfectly fine for me. Thanks a lot to make this project fly!
Alex
On Tue, Nov 3, 2015 at 6:42 PM, Lance Frohman notifications@github.com wrote:
also one off fix option expose default appender,positioner resizing
group set padding
You can view, comment on, or merge this pull request online at:
https://github.com/Genentech/pviz/pull/8 Commit Summary
- new features collapser, selection
File Changes
- M dist/pviz-amd.js https://github.com/Genentech/pviz/pull/8/files#diff-0 (316)
- M dist/pviz-amd.min.js https://github.com/Genentech/pviz/pull/8/files#diff-1 (4)
- M dist/pviz-bundle.js https://github.com/Genentech/pviz/pull/8/files#diff-2 (562)
- M dist/pviz-bundle.min.js https://github.com/Genentech/pviz/pull/8/files#diff-3 (32)
- M dist/pviz-core.css https://github.com/Genentech/pviz/pull/8/files#diff-4 (37)
- M examples/deps/bootstrap-theme.min.css https://github.com/Genentech/pviz/pull/8/files#diff-5 (4)
- M examples/deps/bootstrap.min.css https://github.com/Genentech/pviz/pull/8/files#diff-6 (4)
- M examples/deps/pviz-bundle.min.js https://github.com/Genentech/pviz/pull/8/files#diff-7 (32)
- M examples/deps/pviz-core.css https://github.com/Genentech/pviz/pull/8/files#diff-8 (37)
- M examples/doc/DASReader.js.html https://github.com/Genentech/pviz/pull/8/files#diff-9 (2)
- M examples/doc/DetailsPane.js.html https://github.com/Genentech/pviz/pull/8/files#diff-10 (2)
- M examples/doc/FastaReader.js.html https://github.com/Genentech/pviz/pull/8/files#diff-11 (2)
- M examples/doc/FeatureDisplayer.js.html https://github.com/Genentech/pviz/pull/8/files#diff-12 (17)
- M examples/doc/FeatureLayer.js.html https://github.com/Genentech/pviz/pull/8/files#diff-13 (2)
- M examples/doc/FeatureLayerCollection.js.html https://github.com/Genentech/pviz/pull/8/files#diff-14 (2)
- M examples/doc/FeatureLayerView.js.html https://github.com/Genentech/pviz/pull/8/files#diff-15 (13)
- M examples/doc/FeatureManager.js.html https://github.com/Genentech/pviz/pull/8/files#diff-16 (2)
- M examples/doc/GGplot2Adapter.js.html https://github.com/Genentech/pviz/pull/8/files#diff-17 (2)
- M examples/doc/HiddenLayersView.js.html https://github.com/Genentech/pviz/pull/8/files#diff-18 (2)
- M examples/doc/OneLiner.js.html https://github.com/Genentech/pviz/pull/8/files#diff-19 (2)
- M examples/doc/PositionedFeature.js.html https://github.com/Genentech/pviz/pull/8/files#diff-20 (2)
- M examples/doc/SeqEntry.js.html https://github.com/Genentech/pviz/pull/8/files#diff-21 (2)
- M examples/doc/SeqEntryAnnotInteractiveView.js.html https://github.com/Genentech/pviz/pull/8/files#diff-22 (150)
- M examples/doc/SeqEntryFastaView.js.html https://github.com/Genentech/pviz/pull/8/files#diff-23 (2)
- M examples/doc/SeqEntryTableView.js.html https://github.com/Genentech/pviz/pull/8/files#diff-24 (2)
- M examples/doc/SeqEntryViewport.js.html https://github.com/Genentech/pviz/pull/8/files#diff-25 (108)
- M examples/doc/TypedDisplayer.js.html https://github.com/Genentech/pviz/pull/8/files#diff-26 (32)
- M examples/doc/global.html https://github.com/Genentech/pviz/pull/8/files#diff-27 (2)
- M examples/doc/index.html https://github.com/Genentech/pviz/pull/8/files#diff-28 (2)
- M examples/doc/module-DASReader-DASReader.html https://github.com/Genentech/pviz/pull/8/files#diff-29 (2)
- M examples/doc/module-DASReader.html https://github.com/Genentech/pviz/pull/8/files#diff-30 (2)
- M examples/doc/module-DetailsPane-DetailsPane.html https://github.com/Genentech/pviz/pull/8/files#diff-31 (6)
- M examples/doc/module-DetailsPane.html https://github.com/Genentech/pviz/pull/8/files#diff-32 (2)
- M examples/doc/module-FastaReader-FastaReader.html https://github.com/Genentech/pviz/pull/8/files#diff-33 (2)
- M examples/doc/module-FastaReader.html https://github.com/Genentech/pviz/pull/8/files#diff-34 (2)
- M examples/doc/module-FeatureDisplayer-FeatureDisplayer.html https://github.com/Genentech/pviz/pull/8/files#diff-35 (23)
- M examples/doc/module-FeatureDisplayer.html https://github.com/Genentech/pviz/pull/8/files#diff-36 (2)
- M examples/doc/module-FeatureLayer-FeatureLayer.html https://github.com/Genentech/pviz/pull/8/files#diff-37 (2)
- M examples/doc/module-FeatureLayer.html https://github.com/Genentech/pviz/pull/8/files#diff-38 (2)
- M examples/doc/module-FeatureLayerCollection-FeatureLayerCollection.html https://github.com/Genentech/pviz/pull/8/files#diff-39 (2)
- M examples/doc/module-FeatureLayerCollection.html https://github.com/Genentech/pviz/pull/8/files#diff-40 (2)
- M examples/doc/module-FeatureLayerView-FeatureLayerView.html https://github.com/Genentech/pviz/pull/8/files#diff-41 (8)
- M examples/doc/module-FeatureLayerView.html https://github.com/Genentech/pviz/pull/8/files#diff-42 (2)
- M examples/doc/module-FeatureManager-FeatureManager.html https://github.com/Genentech/pviz/pull/8/files#diff-43 (5)
- M examples/doc/module-FeatureManager.html https://github.com/Genentech/pviz/pull/8/files#diff-44 (2)
- M examples/doc/module-GGPLot2Adapter.html https://github.com/Genentech/pviz/pull/8/files#diff-45 (2)
- M examples/doc/module-HiddenLayersView-HiddenLayersView.html https://github.com/Genentech/pviz/pull/8/files#diff-46 (2)
- M examples/doc/module-HiddenLayersView.html https://github.com/Genentech/pviz/pull/8/files#diff-47 (2)
- M examples/doc/module-OneLiner-OneLiner.html https://github.com/Genentech/pviz/pull/8/files#diff-48 (2)
- M examples/doc/module-OneLiner.html https://github.com/Genentech/pviz/pull/8/files#diff-49 (2)
- M examples/doc/module-PositionedFeature-PositionedFeature.html https://github.com/Genentech/pviz/pull/8/files#diff-50 (2)
- M examples/doc/module-PositionedFeature.html https://github.com/Genentech/pviz/pull/8/files#diff-51 (2)
- M examples/doc/module-SeqEntry-SeqEntry.html https://github.com/Genentech/pviz/pull/8/files#diff-52 (2)
- M examples/doc/module-SeqEntry.html https://github.com/Genentech/pviz/pull/8/files#diff-53 (2)
- M examples/doc/module-SeqEntryAnnotInteractiveView-SeqEntryAnnotInteractiveView.html https://github.com/Genentech/pviz/pull/8/files#diff-54 (309)
- M examples/doc/module-SeqEntryAnnotInteractiveView.html https://github.com/Genentech/pviz/pull/8/files#diff-55 (2)
- M examples/doc/module-SeqEntryFastaView-SeqEntryFastaView.html https://github.com/Genentech/pviz/pull/8/files#diff-56 (2)
- M examples/doc/module-SeqEntryFastaView.html https://github.com/Genentech/pviz/pull/8/files#diff-57 (2)
- M examples/doc/module-SeqEntryTableView-SeqEntryTableView.html https://github.com/Genentech/pviz/pull/8/files#diff-58 (2)
- M examples/doc/module-SeqEntryTableView.html https://github.com/Genentech/pviz/pull/8/files#diff-59 (2)
- M examples/doc/module-SeqEntryViewport-SeqEntryViewport.html https://github.com/Genentech/pviz/pull/8/files#diff-60 (192)
- M examples/doc/module-SeqEntryViewport.html https://github.com/Genentech/pviz/pull/8/files#diff-61 (2)
- M examples/doc/module-TypeDisplayer-TypeDisplayer.html https://github.com/Genentech/pviz/pull/8/files#diff-62 (8)
- M examples/doc/module-TypeDisplayer.html https://github.com/Genentech/pviz/pull/8/files#diff-63 (2)
- A examples/example-collapse.html https://github.com/Genentech/pviz/pull/8/files#diff-64 (226)
- A examples/example-select.html https://github.com/Genentech/pviz/pull/8/files#diff-65 (176)
- A examples/images/example-collapse.jpg https://github.com/Genentech/pviz/pull/8/files#diff-66 (0)
- A examples/images/example-select.jpg https://github.com/Genentech/pviz/pull/8/files#diff-67 (0)
- M examples/index.html https://github.com/Genentech/pviz/pull/8/files#diff-68 (22)
- M src/css/pviz-core.css https://github.com/Genentech/pviz/pull/8/files#diff-69 (37)
- M src/js/views/FeatureDisplayer.js https://github.com/Genentech/pviz/pull/8/files#diff-70 (15)
- M src/js/views/FeatureLayerView.js https://github.com/Genentech/pviz/pull/8/files#diff-71 (11)
- M src/js/views/SeqEntryAnnotInteractiveView.js https://github.com/Genentech/pviz/pull/8/files#diff-72 (148)
- M src/js/views/SeqEntryViewport.js https://github.com/Genentech/pviz/pull/8/files#diff-73 (106)
- M src/js/views/TypedDisplayer.js https://github.com/Genentech/pviz/pull/8/files#diff-74 (30)
Patch Links:
— Reply to this email directly or view it on GitHub https://github.com/Genentech/pviz/pull/8.
Alexandre Masselot
http://alexandre-masselot.blogspot.ch http://alexandre-masselot.blogspot.com// http://alexandre-masselot.blogspot.ch/ h http://mtroopgoeswest.blogspot.ch/ttp://www.framexpeditions.com
Alexandre Masselot
http://alexandre-masselot.blogspot.ch http://alexandre-masselot.blogspot.com// http://alexandre-masselot.blogspot.ch/ h http://mtroopgoeswest.blogspot.ch/ttp://www.framexpeditions.com
also one off fix option expose default appender,positioner resizing group set padding