GeneralMagicio / pairwise-rf6

https://pairwise-rf6-general-magic.vercel.app
MIT License
2 stars 0 forks source link

[Error] number of delegation for each category or budget allocation isn't shown #156

Closed maryjaf closed 5 days ago

maryjaf commented 6 days ago

as you can see in below screen record "some one delegated to me", but in category or budget allocation this copy isn't shown "1 people degated to you" like as before

image

wallet address: 0x523E41A134Ab0999F2dC844eA02d9b53cC28fD1a cc: @mmahdigh

mmahdigh commented 6 days ago

Could you take a look, please? @HrithikSampson

HrithikSampson commented 6 days ago

@maryjaf , I think the copy was changed. cc: @MoeNick

MoeNick commented 6 days ago

Someone delegated to you is correct in the matter of the copy. In the @maryjaf experience, we don't show the deleted number of persons, when the category is voted.

The copy of voted should change to: Voted on behalf of {Delegetedpersons] persons NOTE: if it's only one person, the copy will be person not persons. (remove the s)

@HrithikSampson @maryjaf

HrithikSampson commented 6 days ago

@maryjaf , it is ready to be tested.

maryjaf commented 5 days ago

Thanks @HrithikSampson A space between and 1 is required.

image

and could you please delegate to me "maryjaf" on budget, Governance Leadership and Governance Analytic categories for more testing

HrithikSampson commented 5 days ago

@maryjaf , delegated to you and added space

maryjaf commented 5 days ago

everything related to delegation in category list is shown correctly, thanks @HrithikSampson

image

Only one question how can I be sure 4 people delegated to me

image

HrithikSampson commented 5 days ago

I think that 4 people is like the unique addresses that delegated to you, I had delegated from 3 different wallets because in some I had already voted in one or 2 categories.

I am not sure how to be sure about it.

cc: @mmahdigh @MoeNick

maryjaf commented 5 days ago

Thanks , based on this 4 is correct because one person delegated to me before