search

GeneralMagicio / pairwise-rf6

https://pairwise-rf6-general-magic.vercel.app
MIT License
2 stars 0 forks source link

Categories View for Badgeholders #37

Open MoeNick opened 1 week ago

MoeNick commented 1 week ago

As a bagholder, I wanted my assigned category to be distinguished, so I could more easily select and vote.

Design:

https://www.figma.com/design/tP7Arb2C8aDB05wCVxVVSB/Pairwise-RF6--%3E-Voting-App?node-id=1763-120069&t=ouQwybKxViyhOLEW-4 Image

Success Criteria

MoeNick commented 1 week ago

Just a new use-case added to this view today @Meriem-BM

tagging @mmahdigh to be in the loop

Meriem-BM commented 4 days ago

Hey @MoeNick for Update Ballot can you remind me when should it be disabled?

MoeNick commented 4 days ago

Hey for Ballot

Meriem-BM commented 3 days ago

You can test this @maryjaf, @MoeNick except this, still didn't add

  • if badgholder: disabled until the assigned category is voted
  • If not baddgholder: always enabled. (Mahdi handled it by a modal, if assigned category is not voted) @Meriem-BM
MoeNick commented 3 days ago

@maryjaf you're nt a badgholder. try to decode here https://www.jstoolset.com/jwt image

maryjaf commented 3 days ago

@maryjaf you're nt a badgholder. try to decode here https://www.jstoolset.com/jwt image

image

MoeNick commented 3 days ago

maybe it's a test badge, but what I mean is having it in your jwt token, because we only want this view for OP badgholders based on Agora source, they should be able to update ballot so it's the only source of truth.

maryjaf commented 3 days ago

So please set for this account the badge holder @MoeNick @mmahdigh

MoeNick commented 3 days ago

@maryjaf please test with this address: 0xA1179f64638adb613DDAAc32D918EB6BEB824104 it has badgholder:true on Agora

maryjaf commented 3 days ago

Success Criteria

  • [x] 0. This will be visible to only Badgholders (both guest votes and citizens) you can detect whether user is badgholder or not from the SIWE login done in login flow, the jwt token will have this data.
  • [x] 1. From SIWE login we get the users category (assigned category) - this category plus the budget category should only have the Vote button enabled, they could have a delegated to you badge as well.
  • [x] 2. Other categories will have the vote button disabled.
  • [x] other delegation and voting functionalities should be the same.

this ACs have been passed

the below ACs remain

Hey for Ballot

  • if badgholder: disabled until the assigned category is voted
  • If not baddgholder: always enabled. (Mahdi handled it by a modal, if assigned category is not voted) @Meriem-BM
Meriem-BM commented 3 days ago

Success Criteria

  • [x] 0. This will be visible to only Badgholders (both guest votes and citizens) you can detect whether user is badgholder or not from the SIWE login done in login flow, the jwt token will have this data.

  • [x] 1. From SIWE login we get the users category (assigned category) - this category plus the budget category should only have the Vote button enabled, they could have a delegated to you badge as well.

  • [x] 2. Other categories will have the vote button disabled.

  • [x] other delegation and voting functionalities should be the same.

this ACs have been passed

the below ACs remain

Hey for Ballot

  • if badgholder: disabled until the assigned category is voted

  • If not baddgholder: always enabled. (Mahdi handled it by a modal, if assigned category is not voted)

    @Meriem-BM

Can you test those too, I added in recent merge, thanks

MoeNick commented 2 days ago
MoeNick commented 2 days ago

is this ready for test again? @Meriem-BM ? FYI: @maryjaf

maryjaf commented 2 days ago

could you please remove the vote of this user 0xA1179f64638adb613DDAAc32D918EB6BEB824104 for testing the remaining ACs? @Meriem-BM @mmahdigh