Edit ranking - Githubissues

kristoferlund commented 11 months ago

Use lock instead of stop sign

Even though we internally differentiate between something being locked or disabled, that distinction don't matter to the end user. The result is still that row cannot be edited. I propose we keep using the lock symbol for disabled rows as well, not the stop sign.

Help the user understand what they can edit

Currently the locked rows look almost more prominent than the active ones. Make sure locked rows look toned down / disabled and that the active ones stand out.

Use popovers more effectively.

Remove the "Please enter a valid value.." tooltip, it does not add much value
Add popover on disabled rows: "Complete more rankings in this category to unlock."
Add popover on locked rows: "Row is locked, click the lock icon to unlock"

Signal "Invalid value" more clearly.

A red warning icon next to edit field?
Popover with helpful message: "The entered value is to high/low/something, max/min allowed value for this row is XXX"
No "Invalid value" on save button, instead just make button disabled.

Warn user about the consequences of making manual edits.

Every time user clicks "Edit" button, show popup warning user "After making manual adjustments to a category, you can't do any more pairwise rankings for that category"

Inform user no more pairwise ranking can be done for a category

When manual edits have been done for a category, no more pairwise rankings can be done. Inform the user about this in the context menu. Instead of "Continue ranking →" we should have a disabled text there: "No more ranking can be done"

Help the user differentiate between the levels

We have three levels of rows on this page. Different the colour/opacity slightly for the different level to help guide the user.

mosaeedi commented 11 months ago

1. Use lock instead of stop sign 2. Help the user understand what they can edit

I'm agree that we use just lock and unlocked button instead of having the stop sign. I've made some changes to the locked and unlocked state to fix the ux issue.