search

GeneralMills / pytrends

Pseudo API for Google Trends
Other
3.12k stars 798 forks source link

Update depercated urllib3 methods #584

Open Chrosea opened 1 year ago

Chrosea commented 1 year ago
  1. requests no longer has vendored modules in request.package,
  2. urllib3 deprecated Retry options Retry(method_whitelist=...)in favor of Retry(allowed_methods=...)
Terseus commented 1 year ago

I'm not on my PC right now, I'll take a look on why the pipeline is failing in >3.10 whenever I can.

Terseus commented 1 year ago

Found the problem; I think there's a bug in vcrpy with urllib3 that prevents the test suite to work (see https://github.com/kevin1024/vcrpy/issues/719).

The jobs of Python <3.10 works because vcrpy has pinned urllib3 to v1 with Python <3.10 (see https://github.com/kevin1024/vcrpy/pull/699#issuecomment-1563082822).

Sorry but I would prefer to being able to run the test suite before merging this.

In the mean time, if anyone is having trouble with the urllib3 upgrade, pin urllib3<2 in your requirements until this is fixed.

gl2007 commented 10 months ago

My VSCode was cribbing with this error "Import "requests.packages.urllib3.util" could not be resolved". Had to change it to "from urllib3.util" for the error to go away. I am a newbie here to py.