GeneralNotability / spihelper

WIkipedia sockpuppet investigation helper
MIT License
2 stars 10 forks source link

Edit conflicts during archiving are not handled gracefully #138

Open roysmith opened 1 year ago

roysmith commented 1 year ago

See this edit

I had just left a comment on the SPI and then immediately archived it. SPI helper put up an error about an edit conflict (dirty page cache, I guess), so I just did it again. That ended up archiving it twice. Not fatal, but if there's an easy way to make the two operations atomic, that would be nice.

Dreamy-Jazz commented 1 year ago

There has been several times that SPI pages have their cache not re-generated even after edits. I suspect that, because SPI helper reads from the page content, in general when the edits do not show up to the user SPI helper can only read from the content it gets and attempting to detect conflicts would be difficult.

roysmith commented 1 year ago

I like the second idea (checking if the archive already has the same content)