GeneralPantsuIsBadAtCoding / Azure-Peak

And thus, the curse of F13 spread onto another codebase.
GNU Affero General Public License v3.0
10 stars 70 forks source link

Attempt optimisations to soundloopers and garbage subsystem firing #913

Open noelle-lavenza opened 22 hours ago

noelle-lavenza commented 22 hours ago

Fixes SSGarbage.HandleQueue not cleaning up the queue when it's tick-checked. I think it's pretty important to do this, so now we break from the loop instead of returning when we're tick-checked. Makes soundloopers remove things from the queue in bulk rather than while they're processed. Removes the false assumption that thing.sound_loop() can ever return TRUE to signal that the loop should stop processing. (It didn't even end it properly, it just stopped it from processing.) Fixes a runtime that probably only happens on local because I think the live server has intercept reports off in the config, but it bothered me so fucking bad every time I tested locally.

tgstation-server-azure-peak[bot] commented 13 hours ago

Test Merge Deployed

Details ##### Server Instance Azure Peak ##### Merged By lutowsk ##### Revision Origin: 34de63df15d08d75a611403cfd07f2a90267d6bc Pull Request: b71c20e6af8d28e529758d8b5fc7abbe81ac890f Server: f3ed725b0c85633480ec5c27b1a827fb4187b631 ##### Comment
tgstation-server-azure-peak[bot] commented 2 hours ago

Test Merge Updated

Details ##### Server Instance Azure Peak ##### Merged By lutowsk ##### Revision Origin: c6c7445a4190a37734294a5be3fb807d5f9db917 Pull Request: b71c20e6af8d28e529758d8b5fc7abbe81ac890f Server: c812f4d3e8d1384c7a49b5ed63797bf1bd8fac67 ##### Comment
tgstation-server-azure-peak[bot] commented 2 hours ago

Test Merge Updated

Details ##### Server Instance Azure Peak ##### Merged By lutowsk ##### Revision Origin: f4002d03e99de0d10032343fe95a09800498b0e9 Pull Request: b71c20e6af8d28e529758d8b5fc7abbe81ac890f Server: 4f6ac42a4b33c8d38de6c6f6648366b9ae0036dd ##### Comment