search

GeneralScripting / pipedrive-ruby

31 stars 148 forks source link

Change base_uri to use HTTPS instead of HTTP #33

Open martintajur opened 9 years ago

martintajur commented 9 years ago

Pipedrive will deprecate HTTP API access on May 11, 2015.

martintajur commented 9 years ago

Actually found out it is a duplicate of https://github.com/GeneralScripting/pipedrive-ruby/pull/26 which was submitted already in December 2014.

Please consider merging this — otherwise integrations will break.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-7.73%) to 70.39% when pulling b79c91ea89582787d05511eb7f762311ee15d5e7 on martintajur:patch-1 into e640075da21abcce6b6b2783b0aebaacf25cd98c on GeneralScripting:master.

ronniebermejo commented 9 years ago

Today was the day, and they really did it. :facepunch: I'll implement a quick fix by now. Let me know if there is something I can help with.

thnsk

tzahif1 commented 9 years ago

I see that there is no update to the main release, and my system just not working with Pipedrive anymore ... Can anyone advise how should I use the pull request version instead?

ronniebermejo commented 9 years ago

@tzahif1, This what I am doing: I forked the project, and made the changes right on master, then I am using my own repo until the official gem gets update.

On my gem file replaced the prev gem line with this one: gem 'pipedrive-ruby', :git => 'git://github.com/ronniebermejo/pipedrive-ruby.git'

(I know you can point to any commit/branch from a gem line but not remember how to doi it right now)

tzahif1 commented 9 years ago

Thanks, I realized it earlier and did exactly like you :) it works nice so far. I am just do not understand why such a simple fix could not be fixed in the main project branch.

On May 12, 2015, at 6:42 PM, Ronnie Bermejo notifications@github.com wrote:

@tzahif1 https://github.com/tzahif1, This what I am doing: I forked the project, and made the changes right on master, then I am using my own repo until the official gem gets update.

On my gem file replaced the prev gem line with this one: gem 'pipedrive-ruby', :git => 'git://github.com/ronniebermejo/pipedrive-ruby.git'

(I know you can point to any commit/branch from a gem line but not remember how to doi it right now)

— Reply to this email directly or view it on GitHub https://github.com/GeneralScripting/pipedrive-ruby/pull/33#issuecomment-101324919.