Closed BunaAndy closed 1 year ago
WT-106 - Adding resizing fix for Prev Proj section on landing page https://generatenu.atlassian.net/jira/software/projects/WT/boards/2?selectedIssue=WT-106
Made Prev Proj section resize correctly on desktop by adding in fixes from old resizing branch.
Resized page to smallest possible size and viewed page at different aspect ratios, then ensured text was still readable
Describe in detail steps you used to test the changes you have made. Key Parts
Split section into separate dividers
Changed some elements to scale off of height instead of width
Required checks:
[Yes] Did you conduct a self-review?
Describe aspects of the PR that may become problems in the future. Key Questions
Nothing obvious has come up, this section shouldn't be a problem in the future.
FIGMA
MY VERSION
What was the ticket?
WT-106 - Adding resizing fix for Prev Proj section on landing page https://generatenu.atlassian.net/jira/software/projects/WT/boards/2?selectedIssue=WT-106
What did I do?
Made Prev Proj section resize correctly on desktop by adding in fixes from old resizing branch.
How did I test it?
Resized page to smallest possible size and viewed page at different aspect ratios, then ensured text was still readable
Describe in detail steps you used to test the changes you have made. Key Parts
Split section into separate dividers
Changed some elements to scale off of height instead of width
Required checks:
[Yes] Did you conduct a self-review?
[N/A] Have you written unit or integration tests?
What could go wrong in the future? What parts of your code should the reviewer pay the most attention to?
Describe aspects of the PR that may become problems in the future. Key Questions
Nothing obvious has come up, this section shouldn't be a problem in the future.
Additional comments for the reviewers
Screenshots
FIGMA
MY VERSION