GenerateNU / website

https://generatenu.com
8 stars 0 forks source link

Dev/mobile what we offer #139

Closed garrettladley closed 1 year ago

garrettladley commented 1 year ago

What was the ticket?

WT-29 : Implement Swipeable Carousel for What We Offer Mobile Link to Ticket: https://generatenu.atlassian.net/browse/WT-29

Adjacent to the above ticket so also covered it in this PR, WT-34 : What We Offer Styling to Fix Alignment Bug Link to Ticket: https://generatenu.atlassian.net/browse/WT-34

What did I do?

Implemented a reusable swipeable carousel component to match the Figma. Leveraged this new swipeable carousel component to have Landing/WhatWeOffer on mobile match the Figma. Addressed the alignment bug for what we offer information text.

How did I test it?

Describe in detail steps you used to test the changes you have made.

Compared my implementation to the Figma. Using inspect element, tested at various screen sizes, including edge cases and common screen sizes.

Required checks:

jcui2001 commented 1 year ago

Looks really good! Could you just make the "Software" and "Hardware" texts bigger like it is on Figma? There is also a merge conflict in 1 file, could you see if you can resolve it yourself?