GenerateNU / website

https://generatenu.com
8 stars 0 forks source link

fixed oversized projects container #168

Closed jcui2001 closed 1 year ago

jcui2001 commented 1 year ago

What was the ticket?

Urgent fixed width of container between project carousel and all projects

What did I do?

I removed the list of cards from their containing div and placed them directly under the JSX fragment, and added a container flex div around each card. I also tweaked the mobile CSS to maintain its look.

How did I test it?

I resized the screen to narrow viewport heights and widths, zoomed in and out to the max values, and checked using mobile inspect.

What could go wrong in the future? What parts of your code should the reviewer pay the most attention to?

Whether the relative positioning of the header texts and the cards is appropriate

Additional comments for the reviewers

I implemented a decent mobile look, although the styling will be changed entirely in a different ticket.

Screenshots

MY VERSION

alt text alt text alt text alt text alt text alt text alt text