Closed jcui2001 closed 1 year ago
WT-86 - I worked on adding the mountain image to the Growth Mantra section of the About Page (Landing) Link to Ticket: https://generatenu.atlassian.net/jira/software/projects/WT/boards/2?assignee=63c99b32e28ec74364ccacdc&selectedIssue=WT-86
I changed some of the HTML/CSS properties of the GrowthMantra section to add the mountain image and determine proper sizing
Describe in detail steps you used to test the changes you have made.
Key Parts
I made sure that the mountain was always in view in the center of the page when resizing
I checked that the Figma matched at the default size.
I ensured that the page resized well at low viewport width/high height and low height/high widths.
I ensured that the page did not bleed at high and low magnifications.
I checked the page on various phone sizes. Required checks:
[Yes] Did you conduct a self-review?
[Yes] Have you written unit or integration tests?
Describe aspects of the PR that may become problems in the future. Key Questions
This landing page has its own issues that need to be fixed that may impact the positioning and sizing of the mountain image
I implemented a decent mobile look, although the styling will be changed entirely in a different ticket.
FIGMA
MY VERSION
What was the ticket?
WT-86 - I worked on adding the mountain image to the Growth Mantra section of the About Page (Landing) Link to Ticket: https://generatenu.atlassian.net/jira/software/projects/WT/boards/2?assignee=63c99b32e28ec74364ccacdc&selectedIssue=WT-86
What did I do?
I changed some of the HTML/CSS properties of the GrowthMantra section to add the mountain image and determine proper sizing
How did I test it?
Describe in detail steps you used to test the changes you have made.
Key Parts
I made sure that the mountain was always in view in the center of the page when resizing
I checked that the Figma matched at the default size.
I ensured that the page resized well at low viewport width/high height and low height/high widths.
I ensured that the page did not bleed at high and low magnifications.
I checked the page on various phone sizes. Required checks:
[Yes] Did you conduct a self-review?
[Yes] Have you written unit or integration tests?
What could go wrong in the future? What parts of your code should the reviewer pay the most attention to?
Describe aspects of the PR that may become problems in the future. Key Questions
This landing page has its own issues that need to be fixed that may impact the positioning and sizing of the mountain image
Additional comments for the reviewers
I implemented a decent mobile look, although the styling will be changed entirely in a different ticket.
Screenshots
FIGMA
MY VERSION