GenerateNU / website

https://generatenu.com
8 stars 0 forks source link

Mmccoy/responsive interested and footer #185

Closed MattCMcCoy closed 1 year ago

MattCMcCoy commented 1 year ago

What was the ticket?

WT-5 - fix-responsive-structure-on-the-interested-tab-footer-mobile-and-web

Ticket Link: https://trello.com/c/H99ucxa5/5-fix-responsive-structure-on-the-interested-tab-footer-mobile-and-web

What did I do?

Interested Page:

Footer:

How did I test it?

👀

Describe in detail steps you used to test the changes you have made.

👀

Required checks:

What could go wrong in the future? What parts of your code should the reviewer pay the most attention to?

The css I changed could have effected outside resources without me knowing. Did make the about page interested tab sort of fixed :) without me doing anything or looking at it

Describe aspects of the PR that may become problems in the future.

CSS files.

Additional Comments for the Reviewers

Screenshots

FIGMA

https://www.figma.com/file/IH1czTifLIGVc9jnGa8glU/Generate-Website?type=design&node-id=4237-9267&mode=design&t=dTHIEaeVmm3A7G5o-4

https://www.figma.com/file/IH1czTifLIGVc9jnGa8glU/Generate-Website?type=design&node-id=3908-11505&mode=design&t=nHlACZ4PhRVhjLoZ-4

MY VERSION

Screen Recording 2023-09-26 at 7.57.06 AM.zip

Screenshot 2023-09-26 at 7 59 00 AM

<img width="474" alt="Screenshot 2023-09-26 at 7 59 21 AM" src="https://github.com/GenerateNU/website/assets/59743922/d86c1607-a21d-4378-91c9-f0b04a8b679f">

Screenshot 2023-09-26 at 7 59 43 AM
MattCMcCoy commented 1 year ago

moving the footers into a new file called footer ended up being a ton more files changed that I thought... 😭