search

GenerateNU / website

https://generatenu.com
8 stars 0 forks source link

Next Page Button #76

Closed zachnorman02 closed 1 year ago

zachnorman02 commented 1 year ago

What was the ticket?

WT-70 - I worked on creating the banner that will appear at the end of each page, and added the "About" banner to the end of the landing page Link to Ticket: https://generatenu.atlassian.net/jira/software/projects/WT/boards/2?selectedIssue=WT-70

What did I do?

I created a new component called "NextPage" for the banner. The component takes two props: name and url, to represent the text that should go inside the banner and the url the banner should go to when clicked. I then added the banner to the Landing Page and set it to go to the About page.

How did I test it?

Key Parts

I also had to make the footer a width of 100vw on mobile so the banner would be in the correct position, so there will likely be a merge conflict when my footer branch is merged (though it's only one line so it should be easy to resolve)

Key Questions: N/A

Additional comments for the reviewers

I'm going to play around more with the button width for desktop, so image/code will likely be updated. According to the Figma, the section should be the same width as the footer (and it is), but the button looks wide so I'm going to play around with the button width a bit. Update: played around with this a little more, updated image

Screenshots

Desktop

FIGMA

image

MY VERSION

image

Mobile

FIGMA

image

MY VERSION

image
zachnorman02 commented 1 year ago

How is it breaking? It's based off of main so not all of the mobile stuff is there, but it seems okay for me on my end given that not everything has been merged yet

jcui2001 commented 1 year ago

Yep, I think my browser was bugging, it took a sec to load