search

GenericMadScientist / CHOpt

Star Power optimisation for the masses!
GNU General Public License v3.0
32 stars 4 forks source link

CHOpt doesn't see starpower phrase? #4

Closed Xane8 closed 1 year ago

Xane8 commented 1 year ago

Screenshot 2022-10-16 124646

This one specific phrase in triathlon isn't seen by the program. It doesn't overlap or give you starpower after is this intended or no?

This isn't the first time it happened but i don't remember where was the other instance.

GenericMadScientist commented 1 year ago

What settings did you use to generate this? This is definitely a bug, but even with 0%/0% I get far more points and a different path by m662 when I generate the path.

Xane8 commented 1 year ago

weird, i used default settings, maybe that's the problem CHOpt.exe -f notes.chart -d expert -o triathlon_path.png

default settings image 0%/0% image

GenericMadScientist commented 1 year ago

Okay, I better see what is going on now. The 100%/100% path is correct, and the SP is getting picked up in the calculations because otherwise it would be impossible to activate in m664. It's just that the SP percentage calculation is incorrect (and this is done separately). I'll look into fixing it, but at any rate you can trust the path itself.

The paths are different for 0% and 100% because of reverse squeezing: you need to be able to overlap the entire m660 phrase while not overlapping the m662 phrase, and there are less than two measures between the last notes of each so this requires good squeezing.

As for having less points than when I run it, it turns out that's just because my version of the chart has solo markers while yours does not.

GenericMadScientist commented 1 year ago

Sorry for taking so long to get round to this. Fixed in 1.6.0.