Make review of Jupyter notebooks more convenient

GenericMappingTools / agu24workshop

Mastering Geospatial Visualizations with GMT/PyGMT pre-conference workshop at AGU24

https://www.generic-mapping-tools.org/agu24workshop/

Creative Commons Attribution 4.0 International

10 stars 3 forks source link

Make review of Jupyter notebooks more convenient #9

Open yvonnefroehlich opened 1 week ago

yvonnefroehlich commented 1 week ago

Reviewing Jupyter notebooks directly on GitHub is not very convenient. GitNotebooks can make the review process easier. As an example, I use PR #4

GitHub: https://github.com/GenericMappingTools/agu24workshop/pull/4/files gitnotebooks: https://gitnotebooks.com/GenericMappingTools/agu24workshop/pull/4

Maybe this is helpful for use. Feel free to suggest any other tool which you think can be useful.

(modified from issue https://github.com/GenericMappingTools/pygmt-paper-figures/issues/3)

weiji14 commented 12 hours ago

Hmm, I'm having some trouble putting a review in with gitnotebooks. Am getting some error about Unprocessable Entity: "Pull request review thread path diff too large and Pull request review thread diff hunk can't be blank"

Have you seen this before @yvonnefroehlich? I managed to use GitNotebooks for another repo recently, but not sure why I'm getting this error here.

yvonnefroehlich commented 7 hours ago

Hm. Yes, I also get this error and sofar I could not figure out why this is. And no, so far I did not face this issue in other repos (even without having writting permissions).