Configure "Edit on GitHub" link

[jidanni]

GitHub today has a bug.

In project.rst, please replace

.. include:: explain_distunits.rst_

with

Units
-----

For map distance unit, append *unit* **d** for arc degree, **m** for arc
minute, and **s** for arc second, or **e** for meter [Default unless stated otherwise], **f**
for foot, **k** for km, **M** for statute mile, **n** for nautical mile,
and **u** for US survey foot.

because the material about -j is not applicable to project.

I would create a pull request. Alas today GitHub has a bug.

Thanks.

Also there is a grammar error: 30 degree... needs an "s".

[jidanni]

All I want is to change one paragraph. I don't know why I am also pulling in hundreds of other edits. All I know is I clicked "Edit on GitHub" on https://docs.generic-mapping-tools.org/dev/project.html

[joa-quim]

Delete your fork and create a new one. I suspect that the problem is that you submitting from the master branch instead of from you local branch.

[jidanni]

But master is where that "Edit on GitHub" on https://docs.generic-mapping-tools.org/dev/project.html link now takes us: https://github.com/GenericMappingTools/gmt/edit/master/doc/rst/source/project.rst .

I recall it used to go to some number, but now goes to master.

Hmmm, trying the same thing on proj gives,

https://github.com/OSGeo/PROJ/edit/master/docs/source/operations/index.rst

Also master ...

See also https://github.com/OSGeo/PROJ/issues/3751 .

https://docs.readthedocs.io/en/stable/guides/edit-source-links-sphinx.html shows a version variable.

[seisman]

All I want is to change one paragraph. I don't know why I am also pulling in hundreds of other edits. All I know is I clicked "Edit on GitHub" on https://docs.generic-mapping-tools.org/dev/project.html

It's because you're comparing your PR branch (jidanni-patch-999) with your own master branch, and your master branch is hundreds of commits behind the GMT master branch. You should change the base branch to GenericMappingTools:master when opening PRs.

[jidanni]

It's because you're comparing your PR branch (jidanni-patch-999) with your own master branch, and your master branch is hundreds of commits behind the GMT master branch. You should change the base branch to GenericMappingTools:master when opening PRs.

OK, I'm working on it!

So far looking for a way to change the base branch... None there.

None there.

OK, I'll check settings. Hold on... Thanks.

OK reading https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request ... one moment please.

[jidanni]

Hold on. This is all going to fail, due to the "Protected branch"

[jidanni]

Apparently the new rules became available, https://www.i-programmer.info/news/84-database/16484-github-repository-rules-now-generally-available.html and were applied. But it turns out such rules have certain ramifications...

[PaulWessel]

Master has always been a protected branch, otherwise random people could merge stuff in without review

[jidanni]

All I know is me, Average Joe User, doesn't see the protected stuff on e.g., https://github.com/OSGeo/PROJ I thought someone must have seen the new buttons and clicked on it, but as you say, it was protected all along...

Anyway please do test of how the Average Joe User is supposed to continue submitting pull requests given the new underlying software in effect.

The wrong solution would be to elevate my privileges, because I'm super liable to screw things up.

[PaulWessel]

Maybe @seisman or @maxrjones have suggestions here? No, no elevation will occur.

[seisman]

Anyway please do test of how the Average Joe User is supposed to continue submitting pull requests given the new underlying software in effect.

You just need to click the "Propose changes" button then you'll be redirected to a page like:

Make sure that you select GenericMappingTools/master as the base branch.

[joa-quim]

please do test of how the Average Joe User is supposed to continue submitting pull requests

I also find that Github is quite confuse to use when one do not have commit permissions, but that is not our fault nor is it under our control.

[jidanni]

Ah ha, a vital step is to click "compare against forks" in the upper right: Only then will we be able to choose "GenericMappingTools/master".