Apprently new VS headers (or other Win .h) drop "#define NAN".

GenericMappingTools / gmt

The Generic Mapping Tools

https://www.generic-mapping-tools.org

Other

863 stars 359 forks source link

Apprently new VS headers (or other Win .h) drop "#define NAN". #8627

Closed joa-quim closed 2 days ago

joa-quim commented 2 days ago

This PR defines it when it«s not found (Windows only)

seisman commented 2 days ago

NAN is handled in https://github.com/GenericMappingTools/gmt/blob/fa3eda07161f236a039eb68f5791edcb06850316/src/gmt_notposix.h#L335

Perhaps _Nan._Double is not a constant?

joa-quim commented 2 days ago

I don't know where _Nan._Double is coming from, but since my previous fix seems to solve it (the Win CI built fine), I now moved that NAN definition to gmt_notposix.h

seisman commented 2 days ago

_Nan was originally defined in ymath.h but was moved to another file in https://github.com/microsoft/STL/pull/2828.

joa-quim commented 2 days ago

Deeper than ymath.h. There I looked, but it includes others, that include others ...