search

GenericMappingTools / pygmt

A Python interface for the Generic Mapping Tools.
https://www.pygmt.org
BSD 3-Clause "New" or "Revised" License
759 stars 220 forks source link

xyz2grd wrapper #635

Closed carocamargo closed 3 years ago

carocamargo commented 4 years ago

Hi,

I tried to write a wrapper of the xyz2grd function , in a similar way to the grdfilter wrapper: I added the function to the gridops.py file, and call it in the init.py file. Still, the function doesn't appear when I try to call it. image Maybe it wasn't as simple as change the 'grdcut' to 'grdfilter', but I would expect it to recognise the function anyway, and then give me errors...

xyz2grd The function is used to transform a table/text file into a binary grid file.

Right now I use library to call gmt from python:

os.chdir(path_to_xyzfile) res='60m' infile=flist[0] outfile='../nc/test.nc' command=str('gmt xyz2grd '+str(infile)+' -G'+str(outfile)+' -I'+str(res)+' -Rg') os.system(command)

Any ideas of how I can solve it?

image image image

weiji14 commented 4 years ago

Could you try removing the space at line 222 between @kwargs_to_string and def xyz2grd to see if that helps?

carocamargo commented 4 years ago

Could you try removing the space at line 222 between @kwargs_to_string and def xyz2grd to see if that helps?

It didn't...

seisman commented 4 years ago

@carocamargo It seems you almost finished wrapping xyz2grd. Perhaps you could submit a pull request so that we can comment and improve it together? Of course, it's OK if you want to finish grdfilter (https://github.com/GenericMappingTools/pygmt/pull/616) first.

BTW, xyz2grd is a gridding module. Perhaps better to put it in pygmt/gridding.py, like surface?

carocamargo commented 4 years ago

@carocamargo It seems you almost finished wrapping xyz2grd. Perhaps you could submit a pull request so that we can comment and improve it together? Of course, it's OK if you want to finish grdfilter (#616) first.

BTW, xyz2grd is a gridding module. Perhaps better to put it in pygmt/gridding.py, like surface?

Ok, I think I did a PR for the xyz2grd function (on gridding.py)