search

GenericMappingTools / pygmt

A Python interface for the Generic Mapping Tools.
https://www.pygmt.org
BSD 3-Clause "New" or "Revised" License
758 stars 220 forks source link

GMTInvalidInput error for basemap #730

Closed willschlitzer closed 3 years ago

willschlitzer commented 3 years ago

There is an if statement under basemap in base_plotting.py to raise an exception if B, L, or T aren't included in kwargs. The aliases for basemap do not include T, so that requirement cannot be completed. In #729 I removed "T in kwargs" from the if statement and changed the text of the exception to display the PyGMT parameter names.

It looks like the T parameter on the GMT docs is in reference to adding a compass or rose to the figure; I can add Tm and Td to the list of kwargs to check for if that is the case.

welcome[bot] commented 3 years ago

👋 Thanks for opening your first issue here! Please make sure you filled out the template with as much detail as possible. You might also want to take a look at our contributing guidelines and code of conduct.