search

GenericMappingTools / pygmt

A Python interface for the Generic Mapping Tools.
https://www.pygmt.org
BSD 3-Clause "New" or "Revised" License
747 stars 216 forks source link

The workflow of "GMT Latest Tests" are triggered multiple times #828

Closed seisman closed 3 years ago

seisman commented 3 years ago

Description of the problem

In my recent PR (#827), the workflow of "GMT Latest Tests" are triggered twice (https://github.com/GenericMappingTools/pygmt/actions/runs/524773762, and https://github.com/GenericMappingTools/pygmt/actions/runs/524773759), possibly because I asked two teams for review.

Can we improve the workflow triggering condition? https://github.com/GenericMappingTools/pygmt/blob/8e2b3691f40b8e455885195f7f738bfc979dc845/.github/workflows/ci_tests_dev.yaml#L6-L13

weiji14 commented 3 years ago

Or you could just ask one team at a time to review...

seisman commented 3 years ago

Or you could just ask one team at a time to review...

The problem is that python-maintainers team only has two people (@willschlitzer and I), and @willschlitzer is not in the python team.

Ideally, the python-maintainers team should have all the people in the python team.

weiji14 commented 3 years ago

I'm happy to be added to the python-maintainers team, or we could add @willschlitzer to the python team 😆

seisman commented 3 years ago

Better to redesign the teams to be nested.

weiji14 commented 3 years ago

Better to redesign the teams to be nested.

Agree, but should we do it for the whole https://github.com/orgs/GenericMappingTools/teams organization? I can open up a post on https://github.com/GenericMappingTools/gmt/discussions to discuss

seisman commented 3 years ago

Yes. Please open a discussion.

weiji14 commented 3 years ago

Ok, done at https://github.com/GenericMappingTools/gmt/discussions/4732. Let's leave this issue open for a while.