search

GenesysGo / shadow-drive

Apache License 2.0
71 stars 22 forks source link

In getStorageAccounts(), convert this.wallet.pubKey to base58 string #69

Closed jokumusic closed 1 year ago

jokumusic commented 1 year ago

… this function isn't working because it's not passing an expected base58 string to the memcmp.bytes property.

tracy-codes commented 1 year ago

@khaIilnafis Can you please review this and merge if it's still relevant?

khaIilnafis commented 1 year ago

@jokumusic can you share error logs or steps to replicate getStorageAccounts not working? Have not received any other reports of this and works ok in my tests

jokumusic commented 1 year ago

Unfortunately, I don't remember exactly where it was failing, but I was passing in a PublicKey defined in the @solana/web3.js package. I got my app working by creating a patch: https://github.com/jokumusic/shadow-storage/blob/master/patches/%40shadow-drive%2Bsdk%2B3.0.8.patch This is where the code that uses the shadow-drive package is: https://github.com/jokumusic/shadow-storage/blob/master/src/GlobalProvider.tsx

tracy-codes commented 1 year ago

This issue was replicated by another user, requiring it to be converted .toBase58(). @khaIilnafis please merge this change