search

Genetalks / gtz

A high performance and compression ratio compressor for genomic data, powered by GTXLab of Genetalks.
Other
170 stars 39 forks source link

Installer modifies user's .bashrc without asking or warning the user #19

Open KirillKryukov opened 4 years ago

KirillKryukov commented 4 years ago

Running GTZ installer "https://gtz.io/gtz_latest.run" modifies user's .bashrc file. This intrusion into user's configuration happens silently, without asking, warning or notifying the user.

Few reasons why it's a bad idea:

  1. It's extremely rude to silently mess with user's configuration files.
  2. User may prefer other shell such as zsh (please don't get any ideas).
  3. User may prefer to run gtz using full path, or configure their own aliases or symlinks.
  4. User may already have another command with the same name.

Fortunately && source ~/.bashrc in installation instructions gives it away.

This happens as of GTZ version "PROFESSIONAL-2.1.3-V-2020-03-18 07:11:20"

bolunfeng commented 4 years ago

We modify the .bashrc so that users without root permissions can use it directly after installation.Of course, we did ignore the necessary notifying，and we will add it into the next release.Thank you very much!

KirillKryukov commented 4 years ago

Thanks. I note that this (or any other) issue should not be closed until it has been fixed.