search

Gengrui-Zhang / R2spa

An R Package for Two-Stage Path Analysis (2S-PA)
https://gengrui-zhang.github.io/R2spa/
Other
0 stars 0 forks source link

Update to allow reinitiating pull request #41

Closed marklhc closed 1 year ago

marklhc commented 1 year ago

This is for re-opening PR #38 so that Winnie and I can review and comment on the changes.

winniewytse commented 1 year ago

@marklhc and @Gengrui-Zhang, as I was unable to add comments to this pull request earlier, I added my comments under pull request #38. Would it work for you?

marklhc commented 1 year ago

@marklhc and @Gengrui-Zhang, as I was unable to add comments to this pull request earlier, I added my comments under pull request #38. Would it work for you?

I think I wasn't able to see the comments in the closed PR. Perhaps @Gengrui-Zhang can see them in his email?

marklhc commented 1 year ago

@Gengrui-Zhang, thanks for working on the function. I tried merging in devel, and I think the latest updates in the tspa() function causes some errors in the vignette. Could you check and update the vignette accordingly? Thanks.