GenieClient / Genie4

.NET 6 Update of Genie
GNU General Public License v3.0
21 stars 14 forks source link

Layout shifts down when script starts causing scroll bars to appear #68

Closed DamianDRX closed 2 years ago

DamianDRX commented 2 years ago

No Script Layout Script Active Layout

Attached pictures show the issue, when the script name pops up on the screen, it does not fit in the area designated for it and pushes the windows below it down. If those windows are as tall as they can be, they are pushed outside the area of the window and it causes the scroll bars to become visible until the script is done running at which point the scroll bars disappear. This was not an issue with the previous Genie 3 version.

mj-colonel-panic commented 2 years ago

I'm not seeing the difference between these two screenshots. What is the before state? Sorry, can you circle what changed? Trying to understand.

DamianDRX commented 2 years ago

Apologies for not being more clear, here are the same screen shots with the circled areas that change from the state where a script is not running to a state when the script is active.

No Script Layout Script Active Layout

DamianDRX commented 2 years ago

It seems like when the script name populates in the top left corner of the screen, it creates a graphic larger (vertically) than the space allotted for it to actually take up and therefore pushes everything down just a hair, enough to cause scroll bars to pop up. Hopefully that's more clear.

mj-colonel-panic commented 2 years ago

Ah I totally overlooked that somehow and stared at both for like 5 minutes trying to figure it out lol sorry

This is the only time I've seen this happen - for most people the bar is big enough. Do you have the script bar unchecked under layout? Not sure that would be it though either. image

DamianDRX commented 2 years ago

Nope, just checked, the script bar is indeed checked.

mj-colonel-panic commented 2 years ago

I've been trying to track this down. but being unable to recreate it I haven't seen anything specifically that should cause it. I just made some changes though, can you update to the latest version (4.0.2.2) and let me know if this is still happening?

Kaedan810 commented 2 years ago

Hi - this is still happening in 4.0.2.3. I'm running Genie in Parallels. For some reason, the actual text windows are expanded into the border area - if you look at where it says "game" on the main window, you'll see it's half cut off. Same with all other windows. Wondering if this has anything to do with it.

Screen Shot 2022-03-28 at 10 01 11 AM

Thanks for all your hard work on this!

LaegotKit commented 2 years ago

The fix for this is to run a script, pause it, and re-snap the windows to the client window and re-save your layout. Re-snap by slowly dragging the title bar of each of the windows along the bottom edge up until you see it jump up about one pixel.

image

image

image

mj-colonel-panic commented 2 years ago

@LaegotKit 's steps above resolve this issue. Closing.