search

GenieFramework / SearchLight.jl

ORM layer for Genie.jl, the highly productive Julia web framework
https://genieframework.com
MIT License
139 stars 16 forks source link

Error following tutorial with command SearchLight.Migration.last_up() #20

Closed kurlo closed 4 years ago

kurlo commented 4 years ago

Describe the bug I,m following the tutorial. When I enter SearchLight.Migration.status(): ┌ Warning: getindex(df::DataFrame, col_ind::ColumnIndex) is deprecated, use df[!, col_ind] instead.
│ caller = upped_migrations() at Migration.jl:296
└ @ SearchLight.Migration ~/.julia/packages/SearchLight/KIbzU/src/Migration.jl:296.

After entering SearchLight.Migration.last_up() : Error: Failed executing migration CreateTableBooks up
└ @ SearchLight.Migration ~/.julia/packages/SearchLight/KIbzU/src/Migration.jl:257
ERROR: LoadError: UndefVarError: Migrations not defined
Stacktrace:
[1] include at ./boot.jl:328 [inlined]
[2] include_relative(::Module, ::String) at ./loading.jl:1094
[3] include at ./Base.jl:31 [inlined]
[4] include at /home/pavel/.julia/packages/SearchLight/KIbzU/src/Migration.jl:4 [inlined]
[5] #run_migration#17(::Bool, ::typeof(SearchLight.Migration.run_migration), ::SearchLight.Migration.DatabaseMigration, ::Symbol) at /home/pavel/.julia/packages/SearchLight/KIbzU/src/Migration.jl:245
[6] #run_migration at ./none:0 [inlined]
[7] #last_up#7 at /home/pavel/.julia/packages/SearchLight/KIbzU/src/Migration.jl:114 [inlined]
[8] last_up() at /home/pavel/.julia/packages/SearchLight/KIbzU/src/Migration.jl:114

in expression starting at /home/pavel/Downloads/julia-1.2.0/bin/MyGenieApp/db/migrations/2019092618550668_create_table_books.jl:3

Additional context versioninfo()
Julia Version 1.2.0
Commit c6da87ff4b (2019-08-20 00:03 UTC) Platform Info: OS: Linux (x86_64-pc-linux-gnu)
CPU: Intel(R) Core(TM) i5-4300M CPU @ 2.60GHz
WORD_SIZE: 64
LIBM: libopenlibm LLVM: libLLVM-6.0.1 (ORCJIT, haswell)
Environment:
JULIA_REVISE = auto

Please include the output of julia> versioninfo() st
Status ~/Downloads/julia-1.2.0/bin/MyGenieApp/Project.toml
[c43c736e] Genie v0.18.0 #master (https://github.com/GenieFramework/Genie.jl.git)
[682c06a0] JSON v0.21.0
[e6f89c97] LoggingExtras v0.3.0 [39ec1447] Millboard v0.2.1 [295af30f] Revise v2.2.0 [340e8cb6] SearchLight v0.13.0 #master (https://github.com/GenieFramework/SearchLight.jl.git)

essenciary commented 4 years ago

Thanks for reporting this - I thought I patched all of them warnings :)

sindresops commented 4 years ago

I got this one also, yesterday

essenciary commented 4 years ago

@sindresops I think the error itself is missing?

sindresops commented 4 years ago

Sorry, I just assumed they were identical. Here is the output from

SearchLight.Migration.status()

┌ Warning: 2019-10-25 15:10:10 `getindex(df::DataFrame, col_ind::ColumnIndex)` is deprecated, use `df[!, col_ind]` instead.
│   caller = upped_migrations() at Migration.jl:296
└ @ SearchLight.Migration C:\Users\sindr\.julia\packages\SearchLight\EoLut\src\Migration.jl:296
|   |                  Module name & status  |
|   |                             File name  |
|---|----------------------------------------|
|   |                 CreateTableBooks: DOWN |
| 1 | 2019102513091096_create_table_books.jl |

And then

SearchLight.Migration.last_up()

┌ Error: 2019-10-25 15:10:24 Failed executing migration CreateTableBooks up
└ @ SearchLight.Migration C:\Users\sindr\.julia\packages\SearchLight\EoLut\src\Migration.jl:257
ERROR: LoadError: UndefVarError: Migrations not defined
Stacktrace:
 [1] include at .\boot.jl:328 [inlined]
 [2] include_relative(::Module, ::String) at .\loading.jl:1094
 [3] include at .\Base.jl:31 [inlined]
 [4] include at C:\Users\sindr\.julia\packages\SearchLight\EoLut\src\Migration.jl:4 [inlined]
 [5] #run_migration#17(::Bool, ::typeof(SearchLight.Migration.run_migration), ::SearchLight.Migration.DatabaseMigration, ::Symbol) at C:\Users\sindr\.julia\packages\SearchLight\EoLut\src\Migration.jl:245
 [6] #run_migration at .\none:0 [inlined]
 [7] #last_up#7 at C:\Users\sindr\.julia\packages\SearchLight\EoLut\src\Migration.jl:114 [inlined]
 [8] last_up() at C:\Users\sindr\.julia\packages\SearchLight\EoLut\src\Migration.jl:114
 [9] top-level scope at C:\Users\sindr\.julia\packages\JuliaInterpreter\MXq3U\src\construct.jl:0
in expression starting at D:\WebApps\MyGenieApp\db\migrations\2019102513091096_create_table_books.jl:3

versioninfo()

Julia Version 1.2.0
Commit c6da87ff4b (2019-08-20 00:03 UTC)
Platform Info:
  OS: Windows (x86_64-w64-mingw32)
  CPU: Intel(R) Core(TM) i7-6600U CPU @ 2.60GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, skylake)
Environment:
  JULIA_EDITOR = "C:\Users\sindr\AppData\Local\atom\app-1.40.1\atom.exe"  -a
  JULIA_NUM_THREADS = 2
  JULIA_REVISE = auto
essenciary commented 4 years ago

@sindresops Thanks for the info. Sorry, I didn't understand what you meant, I thought it was a different error. I'm working on a major update and refactoring of SearchLight (clean up and speed up). This will also get fixed in the process, in the next release.

essenciary commented 4 years ago

@kurlo @sindresops Sorry, I missed the point where last_up crashes. Only registered the warning which isn't serious. I pushed a quick fix for the last_up error on the latest master.

sindresops commented 4 years ago

Thank you! I had top change the to SearchLight.Migrations to SearchLight.Migration in the xxxxxx_createTableBooks.jl to get it working after the update

essenciary commented 4 years ago

You're welcome :) If you have a chance to change it back, please let me know if it now works as expected.