search

GenieFramework / StippleUI.jl

StippleUI is a library of reactive UI elements for Stipple.jl.
MIT License
82 stars 15 forks source link

Missing import of @kwdef for early Julia versions #124

Closed yakir12 closed 5 months ago

yakir12 commented 5 months ago

I'm really just trying to help push along some of the work Adrian did in https://github.com/GenieFramework/StippleUI.jl/commit/c2f47b383e86cfd628f699c765d78d40a7c6f9f2 I think you need to add 

Base.VERSION < v"1.8" && import Base.@kwdef

in __init__() somewhere...?

essenciary commented 5 months ago

@yakir12 ah ouch, thanks for pointing this. Maybe easier to just replace @kwdef with Base.@kwdef.

essenciary commented 5 months ago

Done, tagged a new release ;-)

yakir12 commented 5 months ago

ah ouch

I hope you understand I wasn't trying to rush you or anything like that! Had your changes been in a branch I might have been able to PR the change. I'm very grateful for Genie and all you've built here!

essenciary commented 5 months ago

Absolutely no worries, it was a quick fix and I appreciate the heads-up. Had it been a longer fix, I would've asked you if you can submit a PR :)